refactor: migrate from deepin-api-device to deepin-daemon user#132
Merged
Conversation
1. Removed sysusers configuration file for deepin-api-device 2. Updated D-Bus policy configuration to use deepin-daemon 3. Changed service files to run under deepin-daemon user 4. Removed sysusers installation from debian/rules 5. This change consolidates service users under deepin-daemon for better system management refactor: 从 deepin-api-device 迁移到 deepin-daemon 用户 1. 移除了 deepin-api-device 的 sysusers 配置文件 2. 更新 D-Bus 策略配置使用 deepin-daemon 3. 修改服务文件以使用 deepin-daemon 用户运行 4. 从 debian/rules 中移除了 sysusers 安装 5. 此变更有助于统一服务用户管理,使用 deepin-daemon 提高系统管理效率 pms: BUG-311157
deepin pr auto review代码审查意见:
综上所述,这些变更需要仔细检查,确保它们不会对系统的其他部分产生负面影响,并且符合系统的安全策略和权限管理要求。 |
There was a problem hiding this comment.
Hey @18202781743 - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Reviewer's GuideThis PR consolidates service user management by migrating from the deepin-api-device user to deepin-daemon across D-Bus policies, systemd service units, and Debian packaging scripts. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
mhduiy
approved these changes
May 15, 2025
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, mhduiy The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
system management
refactor: 从 deepin-api-device 迁移到 deepin-daemon 用户
pms: BUG-311157
Summary by Sourcery
Migrate service execution and configuration from the deepin-api-device user to deepin-daemon for unified user management
Enhancements:
Chores: