Implicit function definition in hdaps.c

[Hedekar]

I'm hitting a package install error on Ubuntu 25.10 with tp_smapi version 0.44 and it appears as though it's a code-related bug? I may be off base. The config logs read as follows:

DKMS (dkms-3.2.0) make.log for tp_smapi/0.44 for kernel 6.17.0-7-generic (x86_64)
Sat Nov 29 12:15:28 PST 2025

Building module(s)
# command: make -j16 KERNELRELEASE=6.17.0-7-generic -C /lib/modules/6.17.0-7-generic/build M=/var/lib/dkms/tp_smapi/0.44/build HDAPS=1
make: Entering directory '/usr/src/linux-headers-6.17.0-7-generic'
make[1]: Entering directory '/var/lib/dkms/tp_smapi/0.44/build'
warning: the compiler differs from the one used to build the kernel
  The kernel was built by: x86_64-linux-gnu-gcc (Ubuntu 15.2.0-4ubuntu4) 15.2.0
  You are using:           gcc (Ubuntu 15.2.0-4ubuntu4) 15.2.0
  CC [M]  thinkpad_ec.o
  CC [M]  tp_smapi.o
  CC [M]  hdaps.o
hdaps.c: In function ‘hdaps_suspend’:
hdaps.c:430:9: error: implicit declaration of function ‘del_timer_sync’ [-Wimplicit-function-declaration]
  430 |         del_timer_sync(&hdaps_timer);
      |         ^~~~~~~~~~~~~~
make[3]: *** [/usr/src/linux-headers-6.17.0-7-generic/scripts/Makefile.build:287: hdaps.o] Error 1
make[3]: *** Waiting for unfinished jobs....
thinkpad_ec.c: In function ‘check_dmi_for_ec’:
thinkpad_ec.c:471:1: warning: the frame size of 1728 bytes is larger than 1024 bytes [-Wframe-larger-than=]
  471 | }
      | ^
make[2]: *** [/usr/src/linux-headers-6.17.0-7-generic/Makefile:2016: .] Error 2
make[1]: *** [/usr/src/linux-headers-6.17.0-7-generic/Makefile:248: __sub-make] Error 2
make[1]: Leaving directory '/var/lib/dkms/tp_smapi/0.44/build'
make: *** [Makefile:248: __sub-make] Error 2
make: Leaving directory '/usr/src/linux-headers-6.17.0-7-generic'

# exit code: 2
# elapsed time: 08:00:01
----------------------------------------------------------------

Feel free to close this issue if I'm just missing some configuration step or something obvious.

[Hedekar]

This is the command is what caused the above error:

sudo apt upgrade

which resulted in:

Failed command:
make -j16 KERNELRELEASE=6.17.0-7-generic -C /lib/modules/6.17.0-7-generic/build M=/var/lib/dkms/tp_s
mapi/0.44/build HDAPS=1

[evgeni]

It's the same issue that was fixed in #71 and released in 0.45

Please try 0.45.

The package was updated in Debian in August (https://tracker.debian.org/pkg/tp-smapi), no idea why Ubuntu hasn't synced it yet (or tested that the new kernel breaks things).

[Hedekar]

Thanks evgeni, are there any plans to patch the 0.44 version?

[evgeni]

Why would there be? 0.45 is the one you want.

[Hedekar]

Backward patching bugs on previous releases keeps older distribution releases working. I believe Ubuntu's policy is usually to accept bug-fix adjustments to packages, but not newer versions. I could be wrong on this. I'll file the bug on Ubuntu's side and see where it gets to.

[evgeni]

The diff between 0.44 and 0.45 is exactly the fix for this (and a harmless clang fix).

Before filing a bug with Ubuntu, please check if there isn't one open already.