Skip to content

Commit a7ab252

Browse files
committed
playbooks: ansible-lint fix fqcn[action-core]
Generated-by: Claude AI Signed-off-by: Daniel Gomez <da.gomez@samsung.com>
1 parent 3137c07 commit a7ab252

13 files changed

Lines changed: 60 additions & 60 deletions

File tree

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,23 +1,23 @@
11
---
22
- name: Import optional extra_args file
3-
include_vars: "{{ item }}"
3+
ansible.builtin.include_vars: "{{ item }}"
44
ignore_errors: true
55
with_items:
66
- "../extra_vars.yaml"
77
tags: vars
88

99
- name: Filter enabled filesystem configurations
10-
set_fact:
10+
ansible.builtin.set_fact:
1111
enabled_fs_configs: "{{ ai_multifs_configurations | selectattr('enabled', 'equalto', true) | list }}"
1212

1313
- name: Run AI benchmarks on each filesystem configuration
14-
include_tasks: run_single_filesystem.yml
14+
ansible.builtin.include_tasks: run_single_filesystem.yml
1515
loop: "{{ enabled_fs_configs }}"
1616
loop_control:
1717
loop_var: fs_config
1818
index_var: fs_index
1919
when: enabled_fs_configs | length > 0
2020

2121
- name: Generate multi-filesystem comparison report
22-
include_tasks: generate_comparison.yml
22+
ansible.builtin.include_tasks: generate_comparison.yml
2323
when: enabled_fs_configs | length > 1

playbooks/roles/ai_multifs_run/tasks/run_single_filesystem.yml

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,56 +1,56 @@
11
---
22
- name: Display current filesystem configuration
3-
debug:
3+
ansible.builtin.debug:
44
msg: "Testing filesystem configuration {{ fs_index + 1 }}/{{ enabled_fs_configs | length }}: {{ fs_config.name }}"
55

66
- name: Unmount filesystem if mounted
7-
mount:
7+
ansible.posix.mount:
88
path: "{{ ai_multifs_mount_point }}"
99
state: unmounted
1010
ignore_errors: true
1111

1212
- name: Create filesystem with specific configuration
13-
shell: "{{ fs_config.mkfs_cmd }} {{ ai_multifs_device }}"
13+
ansible.builtin.shell: "{{ fs_config.mkfs_cmd }} {{ ai_multifs_device }}"
1414
register: mkfs_result
1515

1616
- name: Display mkfs output
17-
debug:
17+
ansible.builtin.debug:
1818
msg: "mkfs output: {{ mkfs_result.stdout }}"
1919
when: mkfs_result.stdout != ""
2020

2121
- name: Mount filesystem with specific options
22-
mount:
22+
ansible.posix.mount:
2323
path: "{{ ai_multifs_mount_point }}"
2424
src: "{{ ai_multifs_device }}"
2525
fstype: "{{ fs_config.filesystem }}"
2626
opts: "{{ fs_config.mount_opts }}"
2727
state: mounted
2828

2929
- name: Create filesystem-specific results directory
30-
file:
30+
ansible.builtin.file:
3131
path: "{{ ai_multifs_results_dir }}/{{ fs_config.name }}"
3232
state: directory
3333
mode: "0755"
3434

3535
- name: Update AI benchmark configuration for current filesystem
36-
set_fact:
36+
ansible.builtin.set_fact:
3737
current_fs_benchmark_dir: "{{ ai_multifs_mount_point }}/ai-benchmark-data"
3838
current_fs_results_dir: "{{ ai_multifs_results_dir }}/{{ fs_config.name }}"
3939

4040
- name: Create AI benchmark data directory on current filesystem
41-
file:
41+
ansible.builtin.file:
4242
path: "{{ current_fs_benchmark_dir }}"
4343
state: directory
4444
mode: "0755"
4545

4646
- name: Generate AI benchmark configuration for current filesystem
47-
template:
47+
ansible.builtin.template:
4848
src: milvus_config.json.j2
4949
dest: "{{ current_fs_results_dir }}/milvus_config.json"
5050
mode: "0644"
5151

5252
- name: Run AI benchmark on current filesystem
53-
shell: |
53+
ansible.builtin.shell: |
5454
cd {{ current_fs_benchmark_dir }}
5555
python3 {{ playbook_dir }}/roles/ai_run_benchmarks/files/milvus_benchmark.py \
5656
--config {{ current_fs_results_dir }}/milvus_config.json \
@@ -60,11 +60,11 @@
6060
poll: 30
6161

6262
- name: Display benchmark completion
63-
debug:
63+
ansible.builtin.debug:
6464
msg: "Benchmark completed for {{ fs_config.name }}: {{ benchmark_result.stdout_lines[-5:] | default(['No output']) }}"
6565

6666
- name: Record filesystem configuration metadata
67-
copy:
67+
ansible.builtin.copy:
6868
content: |
6969
# Filesystem Configuration: {{ fs_config.name }}
7070
Filesystem Type: {{ fs_config.filesystem }}
@@ -83,7 +83,7 @@
8383
mode: "0644"
8484

8585
- name: Capture filesystem statistics after benchmark
86-
shell: |
86+
ansible.builtin.shell: |
8787
echo "=== Filesystem Usage ===" > {{ current_fs_results_dir }}/filesystem_stats.txt
8888
df -h {{ ai_multifs_mount_point }} >> {{ current_fs_results_dir }}/filesystem_stats.txt
8989
echo "" >> {{ current_fs_results_dir }}/filesystem_stats.txt
@@ -99,6 +99,6 @@
9999
ignore_errors: true
100100

101101
- name: Unmount filesystem after benchmark
102-
mount:
102+
ansible.posix.mount:
103103
path: "{{ ai_multifs_mount_point }}"
104104
state: unmounted

playbooks/roles/ai_multifs_setup/tasks/main.yml

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,57 +1,57 @@
11
---
22
- name: Import optional extra_args file
3-
include_vars: "{{ item }}"
3+
ansible.builtin.include_vars: "{{ item }}"
44
ignore_errors: true
55
with_items:
66
- "../extra_vars.yaml"
77
tags: vars
88

99
- name: Create multi-filesystem results directory
10-
file:
10+
ansible.builtin.file:
1111
path: "{{ ai_multifs_results_dir }}"
1212
state: directory
1313
mode: "0755"
1414

1515
- name: Create mount point directory
16-
file:
16+
ansible.builtin.file:
1717
path: "{{ ai_multifs_mount_point }}"
1818
state: directory
1919
mode: "0755"
2020

2121
- name: Unmount any existing filesystem on mount point
22-
mount:
22+
ansible.posix.mount:
2323
path: "{{ ai_multifs_mount_point }}"
2424
state: unmounted
2525
ignore_errors: true
2626

2727
- name: Install required filesystem utilities
28-
package:
28+
ansible.builtin.package:
2929
name:
3030
- xfsprogs
3131
- e2fsprogs
3232
- btrfs-progs
3333
state: present
3434

3535
- name: Filter enabled filesystem configurations
36-
set_fact:
36+
ansible.builtin.set_fact:
3737
enabled_fs_configs: "{{ ai_multifs_configurations | selectattr('enabled', 'equalto', true) | list }}"
3838

3939
- name: Display enabled filesystem configurations
40-
debug:
40+
ansible.builtin.debug:
4141
msg: "Will test {{ enabled_fs_configs | length }} filesystem configurations: {{ enabled_fs_configs | map(attribute='name') | list }}"
4242

4343
- name: Validate that device exists
44-
stat:
44+
ansible.builtin.stat:
4545
path: "{{ ai_multifs_device }}"
4646
register: device_stat
4747
failed_when: not device_stat.stat.exists
4848

4949
- name: Display device information
50-
debug:
50+
ansible.builtin.debug:
5151
msg: "Using device {{ ai_multifs_device }} for multi-filesystem testing"
5252

5353
- name: Create filesystem configuration summary
54-
copy:
54+
ansible.builtin.copy:
5555
content: |
5656
# AI Multi-Filesystem Testing Configuration
5757
Generated: {{ ansible_date_time.iso8601 }}

playbooks/roles/ai_setup/tasks/main.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@
5050
when: ai_milvus_docker | bool
5151

5252
- name: Setup MinIO using shared role
53-
include_role:
53+
ansible.builtin.include_role:
5454
name: minio_setup
5555
vars:
5656
minio_container_image: "{{ ai_minio_container_image_string }}"

playbooks/roles/common/tasks/main.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@
5656
- infer_uid_and_group|bool
5757

5858
- name: Get primary group ID from user entry
59-
set_fact:
59+
ansible.builtin.set_fact:
6060
user_primary_gid: "{{ getent_running_user.ansible_facts.getent_passwd[target_user][2] }}"
6161
when:
6262
- infer_uid_and_group|bool
@@ -72,15 +72,15 @@
7272
- getent_on_group.rc | default(1) != 0
7373

7474
- name: Override user and group with inferred settings if feature is enabled (group found by name)
75-
set_fact:
75+
ansible.builtin.set_fact:
7676
data_user: "{{ target_user }}"
7777
data_group: "{{ ((getent_on_group.values() | first).values() | first).keys() | first }}"
7878
when:
7979
- infer_uid_and_group|bool
8080
- getent_on_group.rc | default(1) == 0
8181

8282
- name: Override user and group with inferred settings if feature is enabled (group found by GID)
83-
set_fact:
83+
ansible.builtin.set_fact:
8484
data_user: "{{ target_user }}"
8585
data_group: "{{ getent_primary_group.ansible_facts.getent_group.keys() | first }}"
8686
when:

playbooks/roles/gen_hosts/tasks/main.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
tags: vars
1212

1313
- name: Parse declared hosts list when using declared hosts
14-
set_fact:
14+
ansible.builtin.set_fact:
1515
kdevops_declared_hosts: >-
1616
{%- if kdevops_declared_hosts is string -%}
1717
{{ (kdevops_declared_hosts | default('')) | regex_replace(',', ' ') | split() }}
@@ -174,7 +174,7 @@
174174
- not kdevops_use_declared_hosts
175175

176176
- name: Load AI nodes configuration for multi-filesystem setup
177-
include_vars:
177+
ansible.builtin.include_vars:
178178
file: "{{ topdir_path }}/{{ kdevops_nodes }}"
179179
name: guestfs_nodes
180180
when:
@@ -184,7 +184,7 @@
184184
- ansible_hosts_template.stat.exists
185185

186186
- name: Extract AI node names for multi-filesystem setup
187-
set_fact:
187+
ansible.builtin.set_fact:
188188
all_generic_nodes: "{{ guestfs_nodes.guestfs_nodes | map(attribute='name') | list }}"
189189
when:
190190
- kdevops_workflows_dedicated_workflow

playbooks/roles/guestfs/tasks/bringup/main.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
register: defined_vms
99

1010
- name: Debug defined VMs
11-
debug:
11+
ansible.builtin.debug:
1212
msg: "Hostname: {{ inventory_hostname }}, Defined VMs: {{ hostvars['localhost']['defined_vms']['list_vms'] | default([]) }}, Check: {{ inventory_hostname not
1313
in (hostvars['localhost']['defined_vms']['list_vms'] | default([])) }}"
1414

playbooks/roles/kdc/tasks/main.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@
8686
become: true
8787
become_method: sudo
8888
ansible.posix.firewalld:
89-
service: kerberos
89+
ansible.builtin.service: kerberos
9090
permanent: true
9191
immediate: true
9292
state: enabled
@@ -96,7 +96,7 @@
9696
become: true
9797
become_method: sudo
9898
ansible.posix.firewalld:
99-
service: kadmin
99+
ansible.builtin.service: kadmin
100100
permanent: true
101101
immediate: true
102102
state: enabled

playbooks/roles/linux-mirror/tasks/main.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -312,7 +312,7 @@
312312
- name: Ensure NFS firewall rules are set (for root user and if NFS is enabled)
313313
become: true
314314
ansible.posix.firewalld:
315-
service: "{{ item }}"
315+
ansible.builtin.service: "{{ item }}"
316316
permanent: true
317317
state: enabled
318318
immediate: true

playbooks/roles/minio_destroy/tasks/main.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
---
22
- name: Import optional extra_args file
3-
include_vars: "{{ item }}"
3+
ansible.builtin.include_vars: "{{ item }}"
44
ignore_errors: true
55
with_items:
66
- "../extra_vars.yaml"
@@ -19,16 +19,16 @@
1919
ignore_errors: true
2020

2121
- name: Clean up MinIO data directory
22-
file:
22+
ansible.builtin.file:
2323
path: "{{ minio_data_path }}"
2424
state: absent
2525
when: minio_warp_enable_cleanup | default(true) | bool
2626

2727
- name: Clean up temporary Warp results
28-
file:
28+
ansible.builtin.file:
2929
path: "/tmp/warp-results"
3030
state: absent
3131

3232
- name: Display MinIO destroy complete
33-
debug:
33+
ansible.builtin.debug:
3434
msg: "MinIO containers and data have been cleaned up"

0 commit comments

Comments
 (0)