fix: handle terminal middleware without mutating chains#3534
Open
dozyio wants to merge 5 commits into
Open
Conversation
tabcat
reviewed
Jun 8, 2026
| */ | ||
| export interface StreamMiddleware { | ||
| (stream: Stream, connection: Connection, next: (stream: Stream, connection: Connection) => void): void | Promise<void> | ||
| (stream: Stream, connection: Connection, next: (stream: Stream, connection: Connection) => void): void | false | Promise<void | false> |
Member
There was a problem hiding this comment.
should this be void | boolean | Promise<void | boolean>?
Comment on lines
+371
to
+379
| if (result === false) { | ||
| stopChain() | ||
| } else if (result != null) { | ||
| result.then(result => { | ||
| if (result === false) { | ||
| stopChain() | ||
| } | ||
| }).catch(reject) | ||
| } |
tabcat
reviewed
Jun 8, 2026
| /** | ||
| * Stream middleware allows accessing stream data outside of the stream handler | ||
| * | ||
| * Return false to stop the middleware chain without aborting the stream. |
Member
There was a problem hiding this comment.
could said returning true or void lets the middleware continue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes two stream middleware issues:
Adds regression coverage for repeated inbound streams, terminal sync/async middleware, outbound terminal middleware, and throw/reject abort behaviour.
Change checklist