PIC Processor ID Constants

[necrashter]

In picsim.h, some of the PIC processor ID definitions are commented out:

picsim/include/picsim.h

Lines 185 to 198 in cb4ac2e

	// FIXME remove all IDs
	// P16 processors
	#define P16F84A 0x0560
	/*
	#define P16F628 0x07C0
	#define P16F877 0x09A0
	#define P16F628A 0x1060
	#define P16F648A 0x1100
	#define P16F648AICD 0x1120
	#define P16F877A 0x0E20
	*/
	#define P16F777 0x0DE0

Because of this issue, the example in the official docs does not work.

Will the processor IDs be removed in the future? Is it because the differences between these processors are negligible? How should we call pic_init without these constants?

Thanks for your time.

[lcgamboa]

Hi @necrashter ,

I'm sorry, the documentation is not up to date. The definitions were removed because now the list of microcontrollers is created dynamically when compiling/linking the files for each type of microcontroller. To get the ID from the list, you need to use the getprocbyname(const char * procname) function. Below is the updated example code:

#include<picsim/picsim.h>
#include<stdio.h>
 
int main()
{
  int i;
  unsigned char val;
  //microcontroller object
  _pic pic1; 
 
  //set serial port
  pic_set_serial(&pic1, 0, "/dev/tnt2",0,0,0);
  //pic_set_serial(&pic1, 0,"COM2",0,0,0);
 
  //initialization and program loading
  pic_init(&pic1, getprocbyname("P16F628A"), "../../../examples/shift/shift.hex",1,20e6);
 
  //enable print messages of internal instruction execution (slow down the simulation speed) 
  pic1.print=1;
 
  //loop 
  for(i=0;i<1000;i++)
  {
      //execute one instruction cycle      
      pic_step(&pic1);
      //read digital pin 1
      val=pic_get_pin(&pic1, 1);
      //write digital pin 2
      pic_set_pin(&pic1, 2, val);
  }
 
  //free internal memory
  pic_end(&pic1);
} 

As soon as I have time I will update the documentation.

[lcgamboa]

I have updated the documentation. There are a second example of real-time application in docs/examples.

[necrashter]

Hi @lcgamboa,

Thank you for the quick update! My problem has been solved, and I also appreciate the additional example. Please feel free to close this issue, or keep it open to track the progress on // FIXME remove all IDs in code.