From e7e92e8ae8d28387f8385864bbcf6c9ab6dc194c Mon Sep 17 00:00:00 2001 From: Jacob Moore Date: Wed, 25 Feb 2026 12:33:09 -0600 Subject: [PATCH 1/6] Fixing shapes assert --- src/geometry/shapes.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/geometry/shapes.h b/src/geometry/shapes.h index 60b07dae..a0ea4c53 100644 --- a/src/geometry/shapes.h +++ b/src/geometry/shapes.h @@ -24,8 +24,8 @@ class Plane Plane(const ViewCArrayKokkos& position_inp, const ViewCArrayKokkos& normal_inp){ - assert(position_inp.order() = 1 && "Plane constructor requires a 1D ViewCArrayKokkos for position"); - assert(normal_inp.order() = 1 && "Plane constructor requires a 1D ViewCArrayKokkos for normal"); + assert(position_inp.order() == 1 && "Plane constructor requires a 1D ViewCArrayKokkos for position"); + assert(normal_inp.order() == 1 && "Plane constructor requires a 1D ViewCArrayKokkos for normal"); assert(position_inp.extent() == normal_inp.extent() && "Plane constructor requires the position and normal vectors to have the same number of dimensions"); assert(position_inp.extent() >= 2 && "Plane constructor requires at least 2 dimensions"); From 85a0930188ef84691e657a13411d298f53d553ac Mon Sep 17 00:00:00 2001 From: Jacob Moore Date: Wed, 25 Feb 2026 12:58:31 -0600 Subject: [PATCH 2/6] ENH: Fix missing == --- src/geometry/shapes.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/geometry/shapes.h b/src/geometry/shapes.h index a0ea4c53..e9390a91 100644 --- a/src/geometry/shapes.h +++ b/src/geometry/shapes.h @@ -83,7 +83,7 @@ class Circle Circle(const ViewCArrayKokkos& position_inp, const ViewCArrayKokkos& normal_inp, const double radius_inp){ - assert(position_inp.order() = 1 && "Circle constructor requires a 1D ViewCArrayKokkos for position"); + assert(position_inp.order() == 1 && "Circle constructor requires a 1D ViewCArrayKokkos for position"); assert(normal_inp.order() = 1 && "Circle constructor requires a 1D ViewCArrayKokkos for normal"); assert(position_inp.extent() == normal_inp.extent() && "Circle constructor requires the position and normal vectors to have the same number of dimensions"); assert(radius_inp > 0.0 && "Circle constructor requires a positive radius"); From e759ed0becf4d01578ba2cc3106d98280b6a6141 Mon Sep 17 00:00:00 2001 From: Jacob Moore Date: Wed, 25 Feb 2026 13:15:11 -0600 Subject: [PATCH 3/6] BUG: Fix missing =, builds with debug now --- src/geometry/shapes.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/geometry/shapes.h b/src/geometry/shapes.h index e9390a91..1242fb2a 100644 --- a/src/geometry/shapes.h +++ b/src/geometry/shapes.h @@ -84,7 +84,7 @@ class Circle Circle(const ViewCArrayKokkos& position_inp, const ViewCArrayKokkos& normal_inp, const double radius_inp){ assert(position_inp.order() == 1 && "Circle constructor requires a 1D ViewCArrayKokkos for position"); - assert(normal_inp.order() = 1 && "Circle constructor requires a 1D ViewCArrayKokkos for normal"); + assert(normal_inp.order() == 1 && "Circle constructor requires a 1D ViewCArrayKokkos for normal"); assert(position_inp.extent() == normal_inp.extent() && "Circle constructor requires the position and normal vectors to have the same number of dimensions"); assert(radius_inp > 0.0 && "Circle constructor requires a positive radius"); assert(position_inp.extent() >= 2 && "Circle constructor requires at least 2 dimensions"); @@ -152,7 +152,7 @@ class Sphere Sphere(const ViewCArrayKokkos& position_inp, const double radius_inp){ - assert(position_inp.order() = 1 && "Sphere constructor requires a 1D ViewCArrayKokkos for position"); + assert(position_inp.order() == 1 && "Sphere constructor requires a 1D ViewCArrayKokkos for position"); assert(radius_inp > 0.0 && "Sphere constructor requires a positive radius"); assert(position_inp.extent() == 3 && "Sphere constructor requires a 3D ViewCArrayKokkos for position"); From 1a9965ed93e032bfdef3d062f978d84832e53d9f Mon Sep 17 00:00:00 2001 From: Jacob Moore Date: Wed, 25 Feb 2026 13:16:52 -0600 Subject: [PATCH 4/6] ENH: Adding debug build to linux tests --- .github/workflows/Linux.yaml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/Linux.yaml b/.github/workflows/Linux.yaml index 48bddd7b..5a76fa98 100644 --- a/.github/workflows/Linux.yaml +++ b/.github/workflows/Linux.yaml @@ -13,12 +13,14 @@ jobs: matrix: #os: [ubuntu-18.04, ubuntu-latest] os: [ubuntu-latest] - build_type: [serial, openmp] + build_type: [serial, openmp, debug] include: - build_type: serial cmake_flags: -DCMAKE_INSTALL_PREFIX=`pwd` -DCMAKE_BUILD_TYPE=Release -DELEMENTS_ENABLE_SERIAL=ON -DELEMENTS_ENABLE_OPENMP=OFF - build_type: openmp cmake_flags: -DCMAKE_INSTALL_PREFIX=`pwd` -DCMAKE_BUILD_TYPE=Release -DELEMENTS_ENABLE_SERIAL=ON -DELEMENTS_ENABLE_OPENMP=ON + - build_type: debug + cmake_flags: -DCMAKE_INSTALL_PREFIX=`pwd` -DCMAKE_BUILD_TYPE=Debug -DELEMENTS_ENABLE_SERIAL=ON -DELEMENTS_ENABLE_OPENMP=OFF runs-on: ${{matrix.os}} steps: From f1b62385dbd4629164a29715f011fa6c8ea23065 Mon Sep 17 00:00:00 2001 From: Jacob Moore Date: Wed, 25 Feb 2026 13:19:26 -0600 Subject: [PATCH 5/6] ENH: Add debug builds for mac --- .github/workflows/MacOS.yaml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/MacOS.yaml b/.github/workflows/MacOS.yaml index 589a0b73..8fffc819 100644 --- a/.github/workflows/MacOS.yaml +++ b/.github/workflows/MacOS.yaml @@ -13,12 +13,14 @@ jobs: fail-fast: false matrix: os: [macos-11, macos-latest] - build_type: [serial, openmp] + build_type: [serial, openmp, debug] include: - build_type: serial extra_flags: "-DELEMENTS_ENABLE_SERIAL=ON -DELEMENTS_ENABLE_OPENMP=OFF" - build_type: openmp extra_flags: "-DELEMENTS_ENABLE_SERIAL=ON -DELEMENTS_ENABLE_OPENMP=ON" + - build_type: debug + extra_flags: "-DELEMENTS_ENABLE_SERIAL=ON -DELEMENTS_ENABLE_OPENMP=OFF" runs-on: ${{matrix.os}} steps: From 2b170d3d0a4c7ceb5a1b2023232b791a4afc23f7 Mon Sep 17 00:00:00 2001 From: Jacob Moore Date: Wed, 25 Feb 2026 13:20:48 -0600 Subject: [PATCH 6/6] ENH: fixing yaml file --- .github/workflows/MacOS.yaml | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/.github/workflows/MacOS.yaml b/.github/workflows/MacOS.yaml index 8fffc819..fd605b3b 100644 --- a/.github/workflows/MacOS.yaml +++ b/.github/workflows/MacOS.yaml @@ -46,10 +46,16 @@ jobs: # Explicitly hint Bison to CMake just in case BISON_PATH=$(brew --prefix bison)/bin/bison FLEX_PATH=$(brew --prefix flex)/bin/flex + # Determine build type + BUILD_TYPE="Release" + if [[ "${{ matrix.build_type }}" == "debug" ]]; then + BUILD_TYPE="Debug" + fi + # Initialize flags array CMAKE_OPTS=( "-DCMAKE_INSTALL_PREFIX=${{github.workspace}}/install" - "-DCMAKE_BUILD_TYPE=Release" + "-DCMAKE_BUILD_TYPE=$BUILD_TYPE" "-DBISON_EXECUTABLE=$BISON_PATH" "-DFLEX_EXECUTABLE=$FLEX_PATH" )