refactor: fully qualify juce namespace across header-files and specify using namespace in cpp-files

Author: Alexander-Zyurkalov

include/element/application.hpp

@@ -143,7 +143,7 @@ class Application : public juce::JUCEApplication,
         Context& context;
         juce::MidiDeviceListConnection connection;
         juce::WeakReference<MidiSettingsApply>::Master masterReference;
-        friend class WeakReference<MidiSettingsApply>;
+        friend class juce::WeakReference<MidiSettingsApply>;
     };
     std::unique_ptr<MidiSettingsApply> applyMidiSettings;
 #endif

include/element/juce.hpp

@@ -21,6 +21,5 @@
 #include <juce_gui_extra/juce_gui_extra.h>
 #include <juce_osc/juce_osc.h>
 
-using namespace juce; // FIXME: namespace juce
 namespace element {
 }

include/element/ui/standard.hpp

@@ -91,7 +91,7 @@ class StandardContent : public Content,
     std::unique_ptr<NavigationConcertinaPanel> nav;
     friend class ContentContainer;
     std::unique_ptr<ContentContainer> container;
-    StretchableLayoutManager layout;
+    juce::StretchableLayoutManager layout;
     class Resizer;
     friend class Resizer;
     std::unique_ptr<Resizer> bar1;

src/application.cpp

@@ -36,6 +36,8 @@
 #define ELEMENT_FIRST_RUN 0
 #endif
 
+using namespace juce;
+
 namespace element {
 
 static std::atomic<int> sCanShutdown { 0 };

src/engine/mappingengine.hpp

@@ -33,7 +33,7 @@ class MappingEngine
     void stopMapping();
 
     void capture (const bool start = true) { capturedEvent.capture.set (start); }
-    MidiMessage getCapturedMidiMessage() const { return capturedEvent.message; }
+    juce::MidiMessage getCapturedMidiMessage() const { return capturedEvent.message; }
     Control getCapturedControl() const { return capturedEvent.control; }
     CapturedEventSignal& capturedSignal() { return capturedEvent.callback; }
 
@@ -42,7 +42,7 @@ class MappingEngine
     class Inputs;
     std::unique_ptr<Inputs> inputs;
 
-    class CapturedEvent : public AsyncUpdater
+    class CapturedEvent : public juce::AsyncUpdater
     {
     public:
         CapturedEvent() { capture.set (false); }
@@ -55,13 +55,13 @@ class MappingEngine
 
     private:
         friend class MappingEngine;
-        Atomic<bool> capture;
+        juce::Atomic<bool> capture;
         Control control;
-        MidiMessage message;
+        juce::MidiMessage message;
         CapturedEventSignal callback;
     } capturedEvent;
 
-    bool captureNextEvent (ControllerMapInput&, const Control&, const MidiMessage&);
+    bool captureNextEvent (ControllerMapInput&, const Control&, const juce::MidiMessage&);
 };
 
 } // namespace element

src/engine/midipanic.hpp

@@ -25,8 +25,8 @@ class MidiPanic
     /** Write panic messags to a buffer. */
     inline static void write (juce::MidiBuffer& buffer, int ch, int frame)
     {
-        buffer.addEvent (MidiMessage::allNotesOff (ch), frame);
-        buffer.addEvent (MidiMessage::allSoundOff (ch), frame);
+        buffer.addEvent (juce::MidiMessage::allNotesOff (ch), frame);
+        buffer.addEvent (juce::MidiMessage::allSoundOff (ch), frame);
     }
 
     /** Write panic messages on all midi channels in the buffer. */
@@ -47,11 +47,11 @@ class MidiPanic
     inline static std::vector<juce::MidiMessage> messages (int ch)
     {
         std::vector<juce::MidiMessage> msgs;
-        const auto timestamp = Time::getMillisecondCounterHiRes();
-        auto msg = MidiMessage::allNotesOff (ch);
+        const auto timestamp = juce::Time::getMillisecondCounterHiRes();
+        auto msg = juce::MidiMessage::allNotesOff (ch);
         msg.setTimeStamp (timestamp);
         msgs.push_back (msg);
-        msg = MidiMessage::allSoundOff (ch);
+        msg = juce::MidiMessage::allSoundOff (ch);
         msg.setTimeStamp (timestamp);
         msgs.push_back (msg);
         return msgs;
@@ -61,13 +61,13 @@ class MidiPanic
     inline static std::vector<juce::MidiMessage> messages()
     {
         std::vector<juce::MidiMessage> msgs;
-        const auto timestamp = Time::getMillisecondCounterHiRes();
+        const auto timestamp = juce::Time::getMillisecondCounterHiRes();
         for (int ch = 1; ch <= 16; ++ch)
         {
-            auto msg = MidiMessage::allNotesOff (ch);
+            auto msg = juce::MidiMessage::allNotesOff (ch);
             msg.setTimeStamp (timestamp);
             msgs.push_back (msg);
-            msg = MidiMessage::allSoundOff (ch);
+            msg = juce::MidiMessage::allSoundOff (ch);
             msg.setTimeStamp (timestamp);
             msgs.push_back (msg);
         }

src/engine/midipipe.cpp

@@ -13,6 +13,7 @@
 #include "el/midi_buffer.hpp"
 #include "el/factories.hpp"
 
+using namespace juce;
 namespace element {
 
 MidiPipe::MidiPipe()

src/engine/miditranspose.hpp

@@ -27,26 +27,26 @@ class MidiTranspose
     inline int getNoteOffset() const { return offset.get(); }
 
     /** Process a single event */
-    inline static void process (MidiMessage& message, const int offset)
+    inline static void process (juce::MidiMessage& message, const int offset)
     {
         if (message.isNoteOnOrOff())
             message.setNoteNumber (offset + message.getNoteNumber());
     }
 
     /** Process a single event */
-    inline void process (MidiMessage& message) noexcept
+    inline void process (juce::MidiMessage& message) noexcept
     {
         if (message.isNoteOnOrOff())
             message.setNoteNumber (offset.get() + message.getNoteNumber());
     }
 
     /** Process a MidiBuffer */
-    inline void process (MidiBuffer& midi, int numSamples)
+    inline void process (juce::MidiBuffer& midi, int numSamples)
     {
         if (0 == offset.get())
             return;
 
-        MidiMessage msg;
+        juce::MidiMessage msg;
         for (auto m : midi)
         {
             if (m.samplePosition >= numSamples)
@@ -62,8 +62,8 @@ class MidiTranspose
     }
 
 private:
-    Atomic<int> offset { 0 };
-    MidiBuffer output;
+    juce::Atomic<int> offset { 0 };
+    juce::MidiBuffer output;
 };
 
 } // namespace element

src/nodes/audiofileplayer.cpp

@@ -17,6 +17,8 @@
 
 #include "utils.hpp"
 
+using namespace juce;
+
 namespace element {
 
 class AudioFilePlayerEditor;

src/nodes/audiofileplayer.hpp

@@ -9,8 +9,8 @@
 namespace element {
 
 class AudioFilePlayerNode : public BaseProcessor,
-                            public AudioProcessorParameter::Listener,
-                            public AsyncUpdater
+                            public juce::AudioProcessorParameter::Listener,
+                            public juce::AsyncUpdater
 {
 public:
     enum Parameters