Move clspv_options PROPERTY out of COMPILER_AVAILABLE flag#869
Open
rjodinchr wants to merge 1 commit into
Open
Move clspv_options PROPERTY out of COMPILER_AVAILABLE flag#869rjodinchr wants to merge 1 commit into
rjodinchr wants to merge 1 commit into
Conversation
Contributor
Author
|
I need to add a warning when the default value from device_properties is overwritten. |
As other flags regarding clspv options like non_uniform_decoration_broken, we can keep them defined even if the compiler is not available. It cleans device_properties a bit by removing the preprocessor macros. I think config PROPERTY should be always defined to avoid having to deal with macro in device_properties. Also it makes me realize that since we refactor the config management, we were adding the clspv_options twice without good reason, thus I removed once instance of it to avoid duplicate options. This patch also adds a warning message when a device property is explicitly overwritten by a configuration value. The warning is restricted to string, uint32, and boolean types because these types perform a direct replacement. Other types are excluded from this warning as they merge the configuration with the device property rather than overwritting it entirely. Additionally, `print_option()` now returns a `std::string` instead of a `char*`. This refactor simplifies string management and improves memory safety across the configuration logging logic.
Contributor
Author
|
Warning message added. PR description updated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As other flags regarding clspv options like
non_uniform_decoration_broken, we can keep them defined even if the
compiler is not available.
It cleans device_properties a bit by removing the preprocessor macros.
I think config PROPERTY should be always defined to avoid having to
deal with macro in device_properties.
Also it makes me realize that since we refactor the config management,
we were adding the clspv_options twice without good reason, thus I
removed once instance of it to avoid duplicate options.
This patch also adds a warning message when a device property is
explicitly overwritten by a configuration value.
The warning is restricted to string, uint32, and boolean types because
these types perform a direct replacement. Other types are excluded from
this warning as they merge the configuration with the device property
rather than overwritting it entirely.
Additionally,
print_option()now returns astd::stringinstead of achar*. This refactor simplifies string management and improves memorysafety across the configuration logging logic.