Coderrabit suggestions applied. Tests updated. Linter fixes

Author: juanpabloxk

lib/bas/bot/base.rb

@@ -15,7 +15,8 @@ class Base
       attr_accessor :read_response, :process_response, :write_response
 
       def initialize(options, shared_storage_reader, shared_storage_writer = nil)
-        @process_options = options || { close_connections_after_process: true }
+        default_options = { close_connections_after_process: true }
+        @process_options = default_options.merge(options || {})
         @shared_storage_reader = shared_storage_reader
         @shared_storage_writer = shared_storage_writer || shared_storage_reader
       end

lib/bas/shared_storage/POSTGRES.md

@@ -21,10 +21,7 @@ def set_in_process; end
 
       def set_processed; end
 
-      def close_connections
-        # TODO: Leave this method empty after testing
-        puts "Closing connection for #{self.class.name}"
-      end
+      def close_connections; end
 
       protected
 

lib/bas/shared_storage/base.rb

@@ -16,8 +16,9 @@ def query(query)
         results = if query.is_a? String
                     @connection.exec(query)
                   else
-                    sentence, params = query
+                    validate_query(query)
 
+                    sentence, params = query
                     @connection.exec_params(sentence, params)
                   end
 
@@ -28,6 +29,14 @@ def finish
         @connection&.finish
         @connection = nil
       end
+
+      private
+
+      def validate_query(query)
+        return if query.is_a?(Array) && query.size == 2 && query[0].is_a?(String) && query[1].is_a?(Array)
+
+        raise ArgumentError, "Parameterized query must be an array of [sentence (String), params (Array)]"
+      end
     end
   end
 end

lib/bas/utils/postgres/connection.rb

@@ -5,7 +5,7 @@
 
 RSpec.describe Bas::Bot::Base do
   before do
-    @options = {}
+    @options = { close_connections_after_process: true }
     @shared_storage_reader = double(:shared_storage_reader, set_in_process: "in-process", set_processed: "processed",
                                                             close_connections: true)
     @shared_storage_writer = double(:shared_storage_writer, close_connections: true)

spec/bas/bot/base_spec.rb

@@ -37,7 +37,7 @@
     it "creates a new connection with the provided parameters" do
       expect(PG::Connection).to receive(:new).with(connection_params).and_return(pg_connection)
 
-      described_class.new({ connection: connection_params })
+      described_class.new(connection_params)
     end
 
     it "raises an error when connection parameters are invalid" do
@@ -158,11 +158,26 @@
 
         expect do
           connection.query(123)
-        end.to raise_error(NoMethodError)
+        end.to raise_error(ArgumentError)
       end
 
-      # NOTE: The implementation doesn't validate array structure, so malformed arrays
-      # don't raise errors - they just behave unexpectedly
+      it "raises ArgumentError for parameterized query with wrong array size" do
+        expect do
+          connection.query(["SELECT * FROM users WHERE id = $1"])
+        end.to raise_error(ArgumentError, "Parameterized query must be an array of [sentence (String), params (Array)]")
+      end
+
+      it "raises ArgumentError for parameterized query with non-string sentence" do
+        expect do
+          connection.query([1, [1]])
+        end.to raise_error(ArgumentError, "Parameterized query must be an array of [sentence (String), params (Array)]")
+      end
+
+      it "raises ArgumentError for parameterized query with non-array params" do
+        expect do
+          connection.query(["SELECT * FROM users WHERE id = $1", 1])
+        end.to raise_error(ArgumentError, "Parameterized query must be an array of [sentence (String), params (Array)]")
+      end
     end
   end