Autosolve does not always work

[daganzdaanda]

Look at https://www.openstreetmap.org/changeset/118560111 and see that the linked notes are still open.
Sadly, I did not run with the --debug flag.
What I recall doing:
I downloaded a lot of notes with josm to look for things I could work on. I have set JOSM to also download closed notes for 500 days, and a limit of 1000 notes downloaded at once. I may have had more than 1000 notes downloaded.
I looked at a few open notes and saw https://www.openstreetmap.org/note/2442094 which I commented on and set to "remember". Then I worked on https://www.openstreetmap.org/note/2980584 and https://www.openstreetmap.org/note/2695620, also adding a comment and setting them to "remember".
This one https://www.openstreetmap.org/note/3087172 I clicked on "remember" but then decided it should remain open and clicked "forget". I also added a comment there.

I'm not 100% sure whether I first added the comments and afterwards pressed "remember" or if it may have been the other way round, too. But I did similar stuff when I tried to replicate #11 and I never got a problem then...

I also can't say if the comments were uploaded by NoteSolver or if it happened afterwards as I pressed JOSM's "upload changed notes" button.

Here's the JOSM status report after I saw that the notes were not closed.

[daganzdaanda]

Some wild guesses for a possible reason:

• Could there be a problem with just too many notes, since I dl'd a big area full of them?
• Or does "forget note" sometimes clash with comments added through JOSM?

What's clear compared to my previous issue #11: This has nothing to do with interrupting the upload. This time I got a warning about "fixme" tagged things, but I continued the upload.

[daganzdaanda]

Here's the --debug output with a test that did go wrong somehow, I think... but I'm getting confused right now, too many variables... 😕 😖

[daganzdaanda]

It happened again: https://www.openstreetmap.org/changeset/118756500 should have closed three issues. No --debug info, sorry.

This time there were not a lot of notes dl'd, so probably not a memory problem.
I also did not click "forget note".
I added a comment to two of the notes and after that marked them as "remember".
I continued mapping and when I wanted to upload everything, the autosolve dialogue came up where I chose yes. Then the validator had some warnings so I cancelled the upload to fix these.
Again, upload - autosolve - yes - another validator warning - cancel.
So again, fix warnings - upload - autosolve - yes - and now at the third try there were no warnings that I could fix anymore.
I continued to add a few words to the changeset comment and finished the upload. I did not get the message that the notes were being closed / uploaded, but also no error message.

The two comments I added to the notes have been uploaded, but I think I did that "manually" through JOSM (should be visible from the timestamp being different than the changeset timestamp?)

[daganzdaanda]

Wild guess number 3: Could adding something to the changeset comment lead to some issue here?

[daganzdaanda]

This time there was only one note to remember, and it did not get closed:
https://www.openstreetmap.org/changeset/118797668
https://www.openstreetmap.org/note/2078000
Hopefully this gist of JOSM --debug output is helpful for you.

What I did this time:
add comment to note > set to remember
keep working
try upload > autocomplete dialog > yes > validator issues > cancel
repeat until satisfied
then add a few words to prefilled changeset comment > upload to server.
Result: changeset is uploaded, but the note is ignored - the comment is not uploaded, and the note remains open.

[daganzdaanda]

Again I tried unsuccessfully to reproduce the problem with a new JOSM home directory on master.apis.dev.openstreetmap.org
Just adding a few words or characters to the changeset comment is not what makes the plugin forget to close the notes.
I have no idea how to get closer to the problem..... 😢 It seems complicated, maybe there's some interference with other plugins?

[daganzdaanda]

It happened again: https://www.openstreetmap.org/changeset/118931559
JOSM status report
JOSM debug output

[daganzdaanda]

This time I noticed that when I wanted to exit, I got the info from JOSM that there are changed notes that have not been uploaded. So I cancelled the exit to get a status report and the debug output. Then I clicked the upload notes button and afterwards I was able to exit without a reminder from JOSM. The comments that I added to the notes were uploaded, but the notes are still open (Makes sense, JOSM does not know I wanted to close them.)

[daganzdaanda]

And again: Changeset; Josm status; Josm debug
This time I interrupted the upload to fix the validator's warnings again, and with the second try added text to the changeset comment and the changeset sources field.

Any idea what's keeping the notes from being closed automatically?

[daganzdaanda]

Another one:
Changeset; Josm status; Josm debug
This time I did not interrupt the upload.

[daganzdaanda]

@kmpoppe Do you see any plugin I'm using that might be interfering with noteSolver?

[kmpoppe]

Hey @daganzdaanda,

so one problem I'm guessing is that you make changes to the notes without uploading those first before you upload the changeset. That's something I have never tested as to how it might change the state of the note or even prevents closure.
I will give that some thought. Maybe there are ways to detect non uploaded changes and start a "sync" on them first.

The problem with the upload being cancelled due to QA checks by JOSM was something I could never replicate creating weird results.

The exclude any other plugins interfering, could you please find yourself an area and a note, where no QA will interfere (you can check them before you hit the changeset upload) and where you do not add any comments to the note, and then do a simple change, remember the note for closure and upload it? If that gets closed properly on both ends we'd be one step further.

K

[daganzdaanda]

I just did this changeset, only one note remembered, no comment added to the note, only one change, no validation problems, no editing the changeset fields. Having all the same plugins as before installed.
It worked as it should.
I remember that I had some successful auto-closures earlier also with adding a comment to the notes before. So I'll try this again now.

[daganzdaanda]

Yeah, it is possible to add a comment to notes and have them still autoclosed: Changeset

[daganzdaanda]

After you told me in #11 how to do it, I did a whole round of tests on the master dev-server with a clean JOSM: https://master.apis.dev.openstreetmap.org/user/dgda2/history#map=14/80.0695/12.4836
I was even provoking validator issues there, and tried to systematically vary what I did to the notes in what sequence, trying to reproduce the issue but it never showed up...

And before that, I tried in a series of changesets on the normal server with my normal JOSM and plugins, see https://www.openstreetmap.org/changeset/118487490
https://www.openstreetmap.org/changeset/118487490
https://www.openstreetmap.org/changeset/118487620
https://www.openstreetmap.org/changeset/118487724
https://www.openstreetmap.org/changeset/118487885
https://www.openstreetmap.org/changeset/118488008
https://www.openstreetmap.org/changeset/118488517
https://www.openstreetmap.org/changeset/118488909
and the linked notes.
Again, I was not able to get the problem in those "laboratory" conditions.