From 7c2e72a384dcfd0c0a5454f98e03ada9738a65fe Mon Sep 17 00:00:00 2001 From: Dave Laird Date: Fri, 31 Jul 2020 07:35:44 -0700 Subject: [PATCH 1/5] test individual node versions --- .github/workflows/ci.yml | 33 ++++++++++++++++++++++++++++++++- 1 file changed, 32 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index d8997549d..76a6824f4 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -25,7 +25,7 @@ jobs: strategy: matrix: - node-version: [12.x, 10.x] + node-version: [12.x] steps: - name: Checkout Code @@ -51,6 +51,37 @@ jobs: npm --version yarn test:mocha + test-mocha: + name: Mocha Tests - ${{ matrix.node-version }} + runs-on: ubuntu-latest + + strategy: + matrix: + node-version: [10.x] + + steps: + - name: Checkout Code + uses: actions/checkout@v2 + - name: Use Node.js ${{ matrix.node-version }} + uses: actions/setup-node@v1 + with: + node-version: ${{ matrix.node-version }} + - name: Remove test-packages + run: | + rm -rf test-packages + - name: Yarn Install + working-directory: ./packages/ember-cli-fastboot + run: | + yarn install --ignore-engines --frozen-lockfile + - name: Install NPM version 4 + run: | + npm config set spin false + npm install -g npm@4 + - name: Run Mocha Tests + working-directory: ./packages/ember-cli-fastboot + run: | + npm --version + yarn test:mocha test-ember: name: Ember Tests From d57e76e5bd8852a5d171bb4de0eb8b9518e7ed3e Mon Sep 17 00:00:00 2001 From: Dave Laird Date: Fri, 31 Jul 2020 07:36:52 -0700 Subject: [PATCH 2/5] test node 10 --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 76a6824f4..1eb2c043d 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -51,7 +51,7 @@ jobs: npm --version yarn test:mocha - test-mocha: + test-mocha-node-10: name: Mocha Tests - ${{ matrix.node-version }} runs-on: ubuntu-latest From 1e907539d089ffb8262bb5aef1810a47f76c9fb4 Mon Sep 17 00:00:00 2001 From: Dave Laird Date: Fri, 31 Jul 2020 10:19:26 -0700 Subject: [PATCH 3/5] wip --- .github/workflows/ci.yml | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 1eb2c043d..18994de2d 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -23,9 +23,15 @@ jobs: name: Mocha Tests - ${{ matrix.node-version }} runs-on: ubuntu-latest + continue-on-error: ${{ matrix.experimental }} strategy: + fail-fast: false matrix: - node-version: [12.x] + node: 10 + experimental: false + include: + - node: 12 + experimental: true steps: - name: Checkout Code From 80d26fcdd46712aa17b617527a66001b9b5536d5 Mon Sep 17 00:00:00 2001 From: Dave Laird Date: Fri, 31 Jul 2020 11:50:40 -0700 Subject: [PATCH 4/5] do we need to get rid of test packages --- .github/workflows/ci.yml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 18994de2d..682e19a41 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -72,9 +72,7 @@ jobs: uses: actions/setup-node@v1 with: node-version: ${{ matrix.node-version }} - - name: Remove test-packages - run: | - rm -rf test-packages + - name: Yarn Install working-directory: ./packages/ember-cli-fastboot run: | From e261c606cdd32f2481807f28e41b35211c06b0f3 Mon Sep 17 00:00:00 2001 From: Dave Laird Date: Fri, 31 Jul 2020 11:53:33 -0700 Subject: [PATCH 5/5] WIP --- .github/workflows/ci.yml | 53 +++++----------------------------------- 1 file changed, 6 insertions(+), 47 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 682e19a41..d9dab52d8 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -19,57 +19,20 @@ on: - cron: '0 6 * * 0' jobs: - test-mocha: - name: Mocha Tests - ${{ matrix.node-version }} + test-legacy-mocha: + name: Legacy Mocha Tests - ${{ matrix.node-version }} runs-on: ubuntu-latest - continue-on-error: ${{ matrix.experimental }} strategy: fail-fast: false matrix: - node: 10 - experimental: false - include: - - node: 12 - experimental: true + node-version: ['10', '12'] steps: - name: Checkout Code uses: actions/checkout@v2 - name: Use Node.js ${{ matrix.node-version }} - uses: actions/setup-node@v1 - with: - node-version: ${{ matrix.node-version }} - - name: Remove test-packages - run: | - rm -rf test-packages - - name: Yarn Install - working-directory: ./packages/ember-cli-fastboot - run: | - yarn install --ignore-engines --frozen-lockfile - - name: Install NPM version 4 - run: | - npm config set spin false - npm install -g npm@4 - - name: Run Mocha Tests - working-directory: ./packages/ember-cli-fastboot - run: | - npm --version - yarn test:mocha - - test-mocha-node-10: - name: Mocha Tests - ${{ matrix.node-version }} - runs-on: ubuntu-latest - - strategy: - matrix: - node-version: [10.x] - - steps: - - name: Checkout Code - uses: actions/checkout@v2 - - name: Use Node.js ${{ matrix.node-version }} - uses: actions/setup-node@v1 + uses: volta-cli/action@v1 with: node-version: ${{ matrix.node-version }} @@ -77,16 +40,12 @@ jobs: working-directory: ./packages/ember-cli-fastboot run: | yarn install --ignore-engines --frozen-lockfile - - name: Install NPM version 4 - run: | - npm config set spin false - npm install -g npm@4 - name: Run Mocha Tests working-directory: ./packages/ember-cli-fastboot run: | + volta install npm@4 npm --version yarn test:mocha - test-ember: name: Ember Tests runs-on: ${{ matrix.os }} @@ -128,4 +87,4 @@ jobs: - name: Yarn Install run: yarn install --ignore-engines --frozen-lockfile - name: Basic App - run: yarn workspace basic-app test:mocha + run: yarn workspace basic-app test:mocha \ No newline at end of file