phpunit tests running again

[kilgore5]

• Get phpunit tests running again.

  • tests were running cleanly here: a46c4e0 but then mysteriously started giving an error in the next commit 4695fe4 with no changes

  • Error is ElasticsearchTest::test_store_menu Undefined property: WP_Error::$taxonomy

  • Backtrace

    1) ElasticsearchTest::test_store_menu Undefined property: WP_Error::$taxonomy

    /Users/johnroyall/elastic-press/vendor/mu-plugins/wordpress-seo-premium/vendor/yoast/wordpress-                    seo/src/presentations/indexable-term-archive-presentation.php:179
    /Users/johnroyall/elastic-press/vendor/mu-plugins/wordpress-seo-premium/vendor/yoast/wordpress-seo/src/presentations/abstract-presentation.php:64
    /Users/johnroyall/elastic-press/vendor/mu-plugins/wordpress-seo-premium/vendor/yoast/wordpress-seo/src/presenters/title-presenter.php:46
    /private/var/folders/6c/3qv43jh50vq3r1n178nwgfp00000gn/T/wordpress/wp-includes/class-wp-hook.php:324
    /private/var/folders/6c/3qv43jh50vq3r1n178nwgfp00000gn/T/wordpress/wp-includes/plugin.php:205
    /private/var/folders/6c/3qv43jh50vq3r1n178nwgfp00000gn/T/wordpress/wp-includes/general-template.php:1178
    /Users/johnroyall/elastic-press/vendor/mu-plugins/wordpress-seo-premium/vendor/yoast/wordpress-seo/src/presenters/title-presenter.php:34
    /Users/johnroyall/elastic-press/vendor/mu-plugins/wordpress-seo-premium/vendor/yoast/wordpress-seo/src/presenters/abstract-indexable-tag-presenter.php:30
    /Users/johnroyall/elastic-press/vendor/mu-plugins/wordpress-seo-premium/vendor/yoast/wordpress-seo/src/surfaces/values/meta.php:140
    /Users/johnroyall/elastic-press/vendor/mu-plugins/wordpress-seo-premium/vendor/yoast/wordpress-seo/src/actions/indexables/indexable-head-action.php:83
    /Users/johnroyall/elastic-press/includes/seo.php:24
    /Users/johnroyall/elastic-press/includes/seo.php:76
    /Users/johnroyall/elastic-press/includes/serializers.php:89
    /Users/johnroyall/elastic-press/includes/storage.php:44
    /Users/johnroyall/elastic-press/tests/test-elasticsearch.php:96
    

• after investigation it appears to be an error in Yoast that will hopefully be solved with an upgrade

  • internally Yoast gets an "invalid taxonomy" error when using get_terms, but this seems to work fine when queried directly via WP
    • possibly related Undefined property: WP_Error::$taxonomy Yoast/wordpress-seo#18757 (comment)