Skip to content

Modal button-order autodetect is sub-optimal on Linux #6

@ssokolow

Description

@ssokolow

On Linux, your button-order detection uses Windows button ordering.

While there's no reliable way to match Linux button order (It's configurable and the default varies between desktop environments), all data I've been able to find indicates that the majority of Linux users are on desktop environments which default to MacOS button order. (GNOME, Xfce, LXDE, and anything else based on GTK+)

KDE and a newcomer named Razor-Qt are the only ones which default to Windows button order and, since it's controlled by the theme, if the user decides to use a GTK+ theme via QGtkStyle, then it'll obey GTK+'s decision to default to MacOS order too.

Also, there are good, objective reasons that it's better to default to "OK in the corner, the rest to the left" and then make an exception if you detect Windows.

If you really want to be as accurate as possible, use this detection logic:

Is the OS Windows?
    Yes: Put cancel on the right.
    No: Continue to next question.
Is the browser Konqueror, Arora, or rekonq? (QtWebKit-based browsers for Linux)
    Yes: put cancel on the right.
    No: Fall back to putting OK on the right.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions