crit/main_test.go at main · kcons/crit · GitHub

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
//go:build darwin

package main

import (
	"testing"
	"time"
)

func TestFormatPromptString(t *testing.T) {
	now := time.Now()

	tests := []struct {
		name     string
		state    *CritState
		expected string
	}{
		{
			name: "no reviews or authored PRs",
			state: &CritState{
				GeneratedAt:          now,
				Username:             "testuser",
				PullRequests:         []PullRequestState{},
				AuthoredPullRequests: []AuthoredPullRequestState{},
			},
			expected: "👍",
		},
		{
			name: "only reviews",
			state: &CritState{
				GeneratedAt: now,
				Username:    "testuser",
				PullRequests: []PullRequestState{
					{Title: "Test PR 1", URL: "https://github.com/test/repo/pull/1", IsDraft: false},
					{Title: "Test PR 2", URL: "https://github.com/test/repo/pull/2", IsDraft: false},
				},
				AuthoredPullRequests: []AuthoredPullRequestState{},
			},
			expected: "🔍2",
		},
		{
			name: "only authored PRs",
			state: &CritState{
				GeneratedAt:  now,
				Username:     "testuser",
				PullRequests: []PullRequestState{},
				AuthoredPullRequests: []AuthoredPullRequestState{
					{Title: "My PR 1", URL: "https://github.com/test/repo/pull/3", IsDraft: false},
				},
			},
			expected: "🚢1",
		},
		{
			name: "both reviews and authored PRs",
			state: &CritState{
				GeneratedAt: now,
				Username:    "testuser",
				PullRequests: []PullRequestState{
					{Title: "Test PR 1", URL: "https://github.com/test/repo/pull/1", IsDraft: false},
				},
				AuthoredPullRequests: []AuthoredPullRequestState{
					{Title: "My PR 1", URL: "https://github.com/test/repo/pull/3", IsDraft: false},
					{Title: "My PR 2", URL: "https://github.com/test/repo/pull/4", IsDraft: false},
				},
			},
			expected: "🔍1 🚢2",
		},
		{
			name: "draft PRs are excluded from review count",
			state: &CritState{
				GeneratedAt: now,
				Username:    "testuser",
				PullRequests: []PullRequestState{
					{Title: "Draft PR", URL: "https://github.com/test/repo/pull/1", IsDraft: true},
					{Title: "Real PR", URL: "https://github.com/test/repo/pull/2", IsDraft: false},
				},
				AuthoredPullRequests: []AuthoredPullRequestState{},
			},
			expected: "🔍1",
		},
		{
			name: "authored PRs include drafts in count",
			state: &CritState{
				GeneratedAt:  now,
				Username:     "testuser",
				PullRequests: []PullRequestState{},
				AuthoredPullRequests: []AuthoredPullRequestState{
					{Title: "My Draft", URL: "https://github.com/test/repo/pull/3", IsDraft: true},
					{Title: "My PR", URL: "https://github.com/test/repo/pull/4", IsDraft: false},
				},
			},
			expected: "🚢2",
		},
	}

	for _, tt := range tests {
		t.Run(tt.name, func(t *testing.T) {
			result := formatPromptString(tt.state, true)
			if result != tt.expected {
				t.Errorf("formatPromptString() = %q, want %q", result, tt.expected)
			}
		})
	}
}

func TestFormatPromptStringWithColors(t *testing.T) {
	now := time.Now()
	oldTime := now.Add(-25 * time.Hour) // Overdue

	tests := []struct {
		name     string
		state    *CritState
		expected string
	}{
		{
			name: "overdue review",
			state: &CritState{
				GeneratedAt: now,
				Username:    "testuser",
				PullRequests: []PullRequestState{
					{
						Title:     "Old PR",
						URL:       "https://github.com/test/repo/pull/1",
						IsDraft:   false,
						UpdatedAt: &oldTime,
						IsOverdue: true,
					},
				},
				AuthoredPullRequests: []AuthoredPullRequestState{},
			},
			expected: "🔍\x1b[31m1\x1b[0m", // Red color codes
		},
		{
			name: "overdue authored PR",
			state: &CritState{
				GeneratedAt:  now,
				Username:     "testuser",
				PullRequests: []PullRequestState{},
				AuthoredPullRequests: []AuthoredPullRequestState{
					{
						Title:        "Old authored PR",
						URL:          "https://github.com/test/repo/pull/3",
						IsDraft:      false,
						CreatedAt:    &oldTime,
						IsOverdueAge: true,
					},
				},
			},
			expected: "🚢\x1b[31m1\x1b[0m", // Red color codes
		},
	}

	for _, tt := range tests {
		t.Run(tt.name, func(t *testing.T) {
			result := formatPromptString(tt.state, true)
			if result != tt.expected {
				t.Errorf("formatPromptString() = %q, want %q", result, tt.expected)
			}
		})
	}
}

func TestFormatPromptStringWithoutColors(t *testing.T) {
	now := time.Now()
	oldTime := now.Add(-25 * time.Hour) // Overdue
	warningTime := now.Add(-4 * 24 * time.Hour) // Warning age

	tests := []struct {
		name     string
		state    *CritState
		expected string
	}{
		{
			name: "no reviews or authored PRs",
			state: &CritState{
				GeneratedAt:          now,
				Username:             "testuser",
				PullRequests:         []PullRequestState{},
				AuthoredPullRequests: []AuthoredPullRequestState{},
			},
			expected: "👍",
		},
		{
			name: "overdue review without colors",
			state: &CritState{
				GeneratedAt: now,
				Username:    "testuser",
				PullRequests: []PullRequestState{
					{
						Title:     "Old PR",
						URL:       "https://github.com/test/repo/pull/1",
						IsDraft:   false,
						UpdatedAt: &oldTime,
						IsOverdue: true,
					},
				},
				AuthoredPullRequests: []AuthoredPullRequestState{},
			},
			expected: "🔍1", // No color codes
		},
		{
			name: "overdue authored PR without colors",
			state: &CritState{
				GeneratedAt:  now,
				Username:     "testuser",
				PullRequests: []PullRequestState{},
				AuthoredPullRequests: []AuthoredPullRequestState{
					{
						Title:        "Old authored PR",
						URL:          "https://github.com/test/repo/pull/3",
						IsDraft:      false,
						CreatedAt:    &oldTime,
						IsOverdueAge: true,
					},
				},
			},
			expected: "🚢1", // No color codes
		},
		{
			name: "warning age authored PR without colors",
			state: &CritState{
				GeneratedAt:  now,
				Username:     "testuser",
				PullRequests: []PullRequestState{},
				AuthoredPullRequests: []AuthoredPullRequestState{
					{
						Title:        "Warning age PR",
						URL:          "https://github.com/test/repo/pull/4",
						IsDraft:      false,
						CreatedAt:    &warningTime,
						IsWarningAge: true,
					},
				},
			},
			expected: "🚢1", // No color codes
		},
		{
			name: "both overdue review and authored PR without colors",
			state: &CritState{
				GeneratedAt: now,
				Username:    "testuser",
				PullRequests: []PullRequestState{
					{
						Title:     "Old review PR",
						URL:       "https://github.com/test/repo/pull/1",
						IsDraft:   false,
						UpdatedAt: &oldTime,
						IsOverdue: true,
					},
				},
				AuthoredPullRequests: []AuthoredPullRequestState{
					{
						Title:        "Old authored PR 1",
						URL:          "https://github.com/test/repo/pull/3",
						IsDraft:      false,
						CreatedAt:    &oldTime,
						IsOverdueAge: true,
					},
					{
						Title:        "Warning authored PR 2",
						URL:          "https://github.com/test/repo/pull/4",
						IsDraft:      false,
						CreatedAt:    &warningTime,
						IsWarningAge: true,
					},
				},
			},
			expected: "🔍1 🚢2", // No color codes
		},
	}

	for _, tt := range tests {
		t.Run(tt.name, func(t *testing.T) {
			result := formatPromptString(tt.state, false)
			if result != tt.expected {
				t.Errorf("formatPromptString() = %q, want %q", result, tt.expected)
			}
		})
	}
}

func makeThread(resolved bool, lastAuthor string) reviewThread {
	var t reviewThread
	t.IsResolved = resolved
	t.Comments.Nodes = []struct {
		Author struct {
			Login string `json:"login"`
		} `json:"author"`
	}{
		{Author: struct {
			Login string `json:"login"`
		}{Login: lastAuthor}},
	}
	return t
}

func TestHasUnresolvedThreadFromOthers(t *testing.T) {
	tests := []struct {
		name     string
		threads  []reviewThread
		username string
		want     bool
	}{
		{
			name:     "no threads",
			threads:  nil,
			username: "me",
			want:     false,
		},
		{
			name:     "resolved thread from other",
			threads:  []reviewThread{makeThread(true, "reviewer")},
			username: "me",
			want:     false,
		},
		{
			name:     "unresolved thread last comment by self",
			threads:  []reviewThread{makeThread(false, "me")},
			username: "me",
			want:     false,
		},
		{
			name:     "unresolved thread last comment by other",
			threads:  []reviewThread{makeThread(false, "reviewer")},
			username: "me",
			want:     true,
		},
		{
			name: "mix of resolved and unresolved, only resolved from others",
			threads: []reviewThread{
				makeThread(true, "reviewer"),
				makeThread(false, "me"),
			},
			username: "me",
			want:     false,
		},
		{
			name: "mix of resolved and unresolved, unresolved from other",
			threads: []reviewThread{
				makeThread(true, "me"),
				makeThread(false, "reviewer"),
			},
			username: "me",
			want:     true,
		},
		{
			name: "multiple unresolved, one from other",
			threads: []reviewThread{
				makeThread(false, "me"),
				makeThread(false, "me"),
				makeThread(false, "reviewer"),
			},
			username: "me",
			want:     true,
		},
		{
			name: "multiple reviewers, all responded to",
			threads: []reviewThread{
				makeThread(false, "me"),
				makeThread(false, "me"),
			},
			username: "me",
			want:     false,
		},
	}

	for _, tt := range tests {
		t.Run(tt.name, func(t *testing.T) {
			got := hasUnresolvedThreadFromOthers(tt.threads, tt.username)
			if got != tt.want {
				t.Errorf("hasUnresolvedThreadFromOthers() = %v, want %v", got, tt.want)
			}
		})
	}
}