-
-
Notifications
You must be signed in to change notification settings - Fork 179
[Refactor]: Controls and Audio settings to avoid code duplication #322
Copy link
Copy link
Open
Labels
difficulty: easySimple, few changes requiredSimple, few changes requiredgood first issueGood for newcomersGood for newcomershacktoberfestjavaPull requests that update java codePull requests that update java codestatus: help-wantedExtra attention is neededExtra attention is neededtype: enhancementNew feature or requestNew feature or request
Metadata
Metadata
Assignees
Labels
difficulty: easySimple, few changes requiredSimple, few changes requiredgood first issueGood for newcomersGood for newcomershacktoberfestjavaPull requests that update java codePull requests that update java codestatus: help-wantedExtra attention is neededExtra attention is neededtype: enhancementNew feature or requestNew feature or request
Projects
Status
Backlog
👉 Please confirm the following
🤔 Is your proposal related to a problem?
We have two ways to see the controls of the game (to know which button is which) and change the audio settings.
The issue is that if one day we update the style of the audio slider, for instance, or if we add a new key to the game, we will have to make the change TWICE => because of the duplication
😍 Describe the solution you'd like
The goal would be to have two classes or whatever, for the audio and controls, where both, the home screen settings and the pause menu settings can get the main layout / disposition / text and so on. So we write it ONCE the logic and then we adapt according to both settings.
👍️ Describe alternatives you've considered
You can have a look at the PR for the new home screen added: #317 (review)
✍ Additional context
This is the home screen settings
The pause menu setting
You can see, many things are redundant, and I want to avoid THIS.