From 0834b7d48da60b0f88fe099e2bb2ee8411f881b7 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Wed, 29 Apr 2026 19:32:55 +0000 Subject: [PATCH] fix SDO unit tests for flag change - use UID instead of enum index Agent-Logs-Url: https://github.com/jsphuebner/libopeninv/sessions/46a2a764-935f-4494-8156-061c2a519c50 Co-authored-by: jsphuebner <3882041+jsphuebner@users.noreply.github.com> --- test/test_cansdo.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/test/test_cansdo.cpp b/test/test_cansdo.cpp index 5bba665..c54d5c6 100644 --- a/test/test_cansdo.cpp +++ b/test/test_cansdo.cpp @@ -473,7 +473,7 @@ static void sdo_read_strings_initiates_print_request() static void sdo_read_param_flags_default() { // By default flags are FLAG_NONE (0) - SendSdoRequest(SDO_READ, 0x2200, Param::ocurlim, 0); + SendSdoRequest(SDO_READ, 0x2200, Param::GetAttrib(Param::ocurlim)->id, 0); ASSERT(canStub->m_canId == SdoRepId); ASSERT(GetReply()->cmd == SDO_READ_REPLY); @@ -483,14 +483,14 @@ static void sdo_read_param_flags_default() static void sdo_write_and_read_param_flags() { // Set FLAG_HIDDEN on ocurlim - SendSdoRequest(SDO_WRITE, 0x2200, Param::ocurlim, (uint32_t)Param::FLAG_HIDDEN); + SendSdoRequest(SDO_WRITE, 0x2200, Param::GetAttrib(Param::ocurlim)->id, (uint32_t)Param::FLAG_HIDDEN); ASSERT(canStub->m_canId == SdoRepId); ASSERT(GetReply()->cmd == SDO_WRITE_REPLY); ASSERT(Param::GetFlag(Param::ocurlim) == Param::FLAG_HIDDEN); // Read it back - SendSdoRequest(SDO_READ, 0x2200, Param::ocurlim, 0); + SendSdoRequest(SDO_READ, 0x2200, Param::GetAttrib(Param::ocurlim)->id, 0); ASSERT(GetReply()->cmd == SDO_READ_REPLY); ASSERT(GetReply()->data == (uint32_t)Param::FLAG_HIDDEN); } @@ -499,7 +499,7 @@ static void sdo_write_param_flags_clear() { // Pre-set the flag, then clear it via SDO Param::SetFlag(Param::ocurlim, Param::FLAG_HIDDEN); - SendSdoRequest(SDO_WRITE, 0x2200, Param::ocurlim, (uint32_t)Param::FLAG_NONE); + SendSdoRequest(SDO_WRITE, 0x2200, Param::GetAttrib(Param::ocurlim)->id, (uint32_t)Param::FLAG_NONE); ASSERT(canStub->m_canId == SdoRepId); ASSERT(GetReply()->cmd == SDO_WRITE_REPLY);