Skip to content

Remove futz from tests as it make them fail in a small percentage of cases #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
johnlpage merged 1 commit into from
Apr 17, 2026
+10 −10
Merged

Remove futz from tests as it make them fail in a small percentage of cases #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions memex/src/test/java/com/johnlpage/memex/cucumber/steps/InspectionsPreConditionSteps.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ private void deleteInspectionsViaApi(List<Long> idsToDelete) throws JsonProcessi
try {
log.info("apiBaseUrl: {}", apiBaseUrl);
ResponseEntity<String> response = restClient.post()
.uri(apiBaseUrl + "/api/inspections?updateStrategy=UPDATEWITHHISTORY&futz=true")
.uri(apiBaseUrl + "/api/inspections?updateStrategy=UPDATEWITHHISTORY")
.contentType(MediaType.APPLICATION_JSON)
.body(jsonPayload)
.retrieve()
Expand Down Expand Up @@ -158,7 +158,7 @@ private void upsertInspectionsViaApi(List<VehicleInspection> inspections) throws

try {
ResponseEntity<String> response = restClient.post()
.uri(apiBaseUrl + "/api/inspections?updateStrategy=UPDATEWITHHISTORY&futz=true")
.uri(apiBaseUrl + "/api/inspections?updateStrategy=UPDATEWITHHISTORY")
.contentType(MediaType.APPLICATION_JSON)
.body(jsonPayload)
.retrieve()
Expand Down
16 changes: 8 additions & 8 deletions memex/src/test/resources/features/inspections.rest.streams.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@ Feature: Vehicle Inspection REST API - Data Streaming Capabilities
It includes tests for loading multiple inspections in a single stream request and for streaming out existing inspection data in JSON format.

@post @load_stream @sunny_day
Scenario Outline: Successfully load a stream of vehicle inspections with different update strategies and futz options
Scenario Outline: Successfully load a stream of vehicle inspections with different update strategies
Given the vehicle inspections in range 10001-10008 do not exist
When I send a POST request to "/api/inspections?updateStrategy=<strategy>&futz=<futz>" with the payload:
When I send a POST request to "/api/inspections?updateStrategy=<strategy>" with the payload:
"""
[
{
Expand Down Expand Up @@ -54,18 +54,18 @@ Feature: Vehicle Inspection REST API - Data Streaming Capabilities
And the response should contain "success": true

Examples:
| strategy | futz | id1 | id2 |
| REPLACE | false | 10001 | 10002 |
| UPDATE | false | 10003 | 10004 |
| UPDATEWITHHISTORY | true | 10005 | 10006 |
| REPLACE | true | 10007 | 10008 |
| strategy | id1 | id2 |
| REPLACE | 10001 | 10002 |
| UPDATE | 10003 | 10004 |
| UPDATEWITHHISTORY | 10005 | 10006 |
| REPLACE | 10007 | 10008 |

@post @load_stream @sunny_day
Scenario: Successfully delete a vehicle inspection
Given the following vehicle inspections exist:
| vehicleinspection |
| {"testid": 10007} |
When I send a POST request to "/api/inspections?updateStrategy=UPDATEWITHHISTORY&futz=true" with the payload:
When I send a POST request to "/api/inspections?updateStrategy=UPDATEWITHHISTORY" with the payload:
"""
[
{
Expand Down
Loading