Skip to content

Test: swapThreshold/invertSwap/direction suite skipped (CSS-positioned fixture needed) #77

@jjeff

Description

@jjeff

Problem

The whole describe block in `tests/e2e/swap-behavior.spec.ts` is `test.describe.skip` (line 7) because:

Swap threshold calculations depend on proper CSS positioning and getBoundingClientRect. The functionality is implemented but needs visual layout for testing.

Four inner tests are blocked:

  • `swap-behavior.spec.ts:18` — should respect swapThreshold option
  • `swap-behavior.spec.ts:75` — should handle invertSwap option
  • `swap-behavior.spec.ts:119` — should respect direction option for horizontal sorting
  • `swap-behavior.spec.ts:167` — should use invertedSwapThreshold when invertSwap is true

Suggested approach

The tests construct their fixtures via `page.evaluate` and `document.createElement` but don't apply realistic CSS to the surrounding page. The PR2/PR3/PR4 fallback-mode tests in `fallback-mode.spec.ts` use a similar inline-fixture pattern but configure `position: absolute` + dimensions explicitly, which makes `getBoundingClientRect` predictable.

Mirror that pattern here: give each fixture an absolute position, explicit item heights, and predictable layout. Then re-enable the describe block.

Refs #35 — discovered during E2E skip triage.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingtestTest coverage / quality

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions