Version 3.0.0 doesn't properly handle Published events in ExecuteAndWaitForSent method

[pelikak]

Hello @jbogard!

I have a problem with v3.0.0 of this package (I am using NServiceBus v8.0.0).
The ExecuteAndWaitForSent doesn't properly handle published events. I suppose there is a missing case in ExecuteAndWait method.
For now I created workaround adding ExecuteAndWaitForPublish method with the missing bit:

case "NServiceBus.Diagnostics.PublishMessage":
    var outgoingContext = activitySource.GetTagItem("testing.outgoing.message.context") as IOutgoingLogicalMessageContext;

    outgoingMessageContexts.Add(outgoingContext);

    if (outgoingContext is TMessageContext ctx2 && predicate(ctx2))
    {
        messageReceivingTaskSource.SetResult(null);
    }

    break;

It would be great if you find a time to fix it.

Thanks!

[jbogard]

Feel free to open a PR with a test! I'm pretty swamped to look into this myself.

[pelikak]

This problem was already fixed in 4.0.0 version, so I cannot create PR. Unfortunately, version v4.0.0 also requires update to NSB v9, so the problem left in NSB v8. I created a new Tag 3.0.1 with the fix in my fork with updated test. A new release from this tag would be helpful for people who still use NSB v8.
Thank you!