From b7acc531b778e074700e205752bd16cb3d6cc41a Mon Sep 17 00:00:00 2001 From: Xianming Zhong Date: Sat, 8 Oct 2016 18:11:02 +0800 Subject: [PATCH 1/2] fix SortableContainer as props filter --- README.md | 2 +- src/index.js | 14 ++++---------- 2 files changed, 5 insertions(+), 11 deletions(-) diff --git a/README.md b/README.md index 1c04160..f801f7b 100644 --- a/README.md +++ b/README.md @@ -70,7 +70,7 @@ import { SortableContainer } from 'react-anything-sortable'; class SortableItem extends React.Component { render() { return ( - +
your item
diff --git a/src/index.js b/src/index.js index dfb965d..b6bbe97 100644 --- a/src/index.js +++ b/src/index.js @@ -506,19 +506,13 @@ const Sortable = React.createClass({ const SortableContainer = ({ className, style, onMouseDown, onTouchStart, children, }) => { - if (React.isValidElement(children)) { - return React.cloneElement(children, { - className, style, onMouseDown, onTouchStart - }); - } else { - return React.createElement('div', { - className, style, onMouseDown, onTouchStart, children - }); - } + return React.createElement('div', { + className, style, onMouseDown, onTouchStart, children + }); }; Sortable.SortableItemMixin = SortableItemMixin(); Sortable.sortable = SortableItemMixin; -Sortable.SortableContainer = SortableItemMixin(SortableContainer); +Sortable.SortableContainer = SortableContainer; export default Sortable; From f33613b470e4bb706f1685b68e0c20d5bcaa20d5 Mon Sep 17 00:00:00 2001 From: Xianming Zhong Date: Mon, 10 Oct 2016 10:54:28 +0800 Subject: [PATCH 2/2] fix the demo to pass tests --- demo/components/DemoContainerItem.js | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/demo/components/DemoContainerItem.js b/demo/components/DemoContainerItem.js index 112f95a..d4ca518 100644 --- a/demo/components/DemoContainerItem.js +++ b/demo/components/DemoContainerItem.js @@ -1,5 +1,15 @@ import React from 'react'; -import { SortableContainer } from '../../src/index.js'; +import { sortable, SortableContainer } from '../../src/index.js'; -export default SortableContainer; +@sortable +class DemoContainerItem extends React.Component { + render() { + return ( + + {this.props.children} + + ); + } +} +export default DemoContainerItem;