feat: develop inside a dev container with nested docker daemon#175
Open
itzcull wants to merge 4 commits into
Open
feat: develop inside a dev container with nested docker daemon#175itzcull wants to merge 4 commits into
itzcull wants to merge 4 commits into
Conversation
Move the inner loop (Postgres, Vite, Vitest, Playwright, testcontainers) into a per-workspace dev container running docker-in-docker. The root docker-compose.yml stays the single source of truth for app services and is brought up against the container's nested daemon, so multiple Conductor workspaces no longer collide on host port 5432, the host docker daemon, or shared node_modules/pnpm state. CI migrates every job to devcontainers/ci@v0.4 so it runs against the same image used locally.
Revert the AGENTS.md tweak from the previous commit. The agent sees a docker host either way; it doesn't need to know about the dev container.
v0.4 does not exist; v0.3 is the current moving tag.
Drop the CI migration to devcontainers/ci; keep CI on the original host-runner setup. The devcontainer changes for local dev remain.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.devcontainer/(workspace image + DinD feature + lifecycle scripts) so each Conductor workspace gets its own per-workspacenode_modules, pnpm store, and nested docker daemon.docker-compose.ymlstays the single source of truth for app services (Postgres today) and is brought up against the container's nested daemon bypostCreateCommand/postStartCommand— so two workspaces never collide on host port 5432, the host docker daemon, or shared state.devcontainers/ci@v0.4so CI runs against the same image used locally; drops the per-jobsetup-node/pnpm install/playwright installtriplets and theservices: postgresblock fromtest-e2e.Test plan
devcontainer up --workspace-folder .completes;post-create.shfinishes installing deps, browsers, and bringing up root compose.pg_isready -h localhost -p 5432 -U localsucceeds; on the hostlsof -iTCP:5432is empty.pnpm test:unit,pnpm test:browser,pnpm test:integration,pnpm test:e2e,pnpm run ciall pass inside the container.pnpm test:integrationin parallel without collision.