Define ownership of QSharedMemory* pointer

[michaelhubatka]

The QSharedMemory object is currently dynamically allocated using the new operator

d->memory = new QSharedMemory( d->blockServerName );

and finally deleted in the abortSafely() function.

I suggest to define an ownership for the pointer. Either by defining a QObject parent in the constructor or by using a std::uniqe_ptr.

This will increase the probability that the destructor of the QSharedMemory object is called for unintended program flows.

[itay-grudev]

We are aware of multiple issues with Qt's latest implementation of QSharedMemory and QSystemSemaphore and even the latter is not truly thread safe.

Honestly I don't thing than any more changes will yield more safety and it's rather pointless. When the new implementation based on QLocalSocket is online I think this issue will become obsolete.