From 7a6da1a149e8ebf73c75466783229ac3c3bcbf67 Mon Sep 17 00:00:00 2001 From: turner Date: Wed, 11 Mar 2026 19:42:44 -0400 Subject: [PATCH 1/2] Git Issue #2074 - Sample names button becomes disabled after removing and re-adding variant tracks --- dev/variant/sampleNamesButtonTest.html | 73 ++++++++++++++++++++++++++ js/browser.js | 4 +- 2 files changed, 75 insertions(+), 2 deletions(-) create mode 100644 dev/variant/sampleNamesButtonTest.html diff --git a/dev/variant/sampleNamesButtonTest.html b/dev/variant/sampleNamesButtonTest.html new file mode 100644 index 000000000..584d5a19d --- /dev/null +++ b/dev/variant/sampleNamesButtonTest.html @@ -0,0 +1,73 @@ + + + + + + Sample Names Button Test (#2074) + + + + + +

Issue #2074 - Sample Names Button Test

+
+ + +
+
+ Steps to reproduce:
+ 1. On load, sample names should be visible (showSampleNames: true)
+ 2. Click "Remove All Variant Tracks"
+ 3. Click "Add Variant Track"
+ 4. Verify: sample names button should be enabled and sample names visible
+
+ Bug behavior: after step 3, the button appears but is disabled +
+ +
+ + + + + diff --git a/js/browser.js b/js/browser.js index 50a237aff..db8d054bb 100755 --- a/js/browser.js +++ b/js/browser.js @@ -132,8 +132,8 @@ class Browser { // sample names this.sampleNameViewportWidth = undefined - this.showSampleNames = false - this.sampleNameControl.setState(this.showSampleNames) + // this.showSampleNames = false + // this.sampleNameControl.setState(this.showSampleNames) this.sampleNameControl.hide() this.layoutChange() From e6eb313b0dcd65ce405e023eb9cd7889e1a9f96d Mon Sep 17 00:00:00 2001 From: turner Date: Wed, 11 Mar 2026 19:45:03 -0400 Subject: [PATCH 2/2] misc --- js/browser.js | 2 -- 1 file changed, 2 deletions(-) diff --git a/js/browser.js b/js/browser.js index db8d054bb..3574899e1 100755 --- a/js/browser.js +++ b/js/browser.js @@ -132,8 +132,6 @@ class Browser { // sample names this.sampleNameViewportWidth = undefined - // this.showSampleNames = false - // this.sampleNameControl.setState(this.showSampleNames) this.sampleNameControl.hide() this.layoutChange()