Skip to content

Typescript Cleanup#6

Merged
mshriver merged 2 commits into
mainfrom
ts-move-cleanup
Nov 5, 2025
Merged

Typescript Cleanup#6
mshriver merged 2 commits into
mainfrom
ts-move-cleanup

Conversation

@mshriver
Copy link
Copy Markdown
Contributor

@mshriver mshriver commented Nov 5, 2025

Remove unneeded files

Summary by Sourcery

Clean up project by removing obsolete configuration and legacy JavaScript test files

Chores:

  • Remove legacy Babel and Mocha configuration files (.babelrc and mocha.opts)
  • Delete outdated JavaScript API and model test specs under test/api and test/model
  • Update yarn.lock to reflect cleanup of dependencies

Copilot AI review requested due to automatic review settings November 5, 2025 14:30
@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented Nov 5, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Removed legacy JavaScript test suites and obsolete build configuration files now redundant after migrating to TypeScript.

File-Level Changes

Change Details Files
Removed legacy JavaScript test files
  • Deleted all API spec tests
  • Deleted all model spec tests
test/api/ArtifactApi.spec.js
test/api/GroupApi.spec.js
test/api/HealthApi.spec.js
test/api/ImportApi.spec.js
test/api/ProjectApi.spec.js
test/api/ReportApi.spec.js
test/api/ResultApi.spec.js
test/api/RunApi.spec.js
test/api/WidgetApi.spec.js
test/api/WidgetConfigApi.spec.js
test/model/Artifact.spec.js
test/model/ArtifactList.spec.js
test/model/Group.spec.js
test/model/GroupList.spec.js
test/model/Health.spec.js
test/model/HealthInfo.spec.js
test/model/InlineObject.spec.js
test/model/InlineObject1.spec.js
test/model/InlineResponse200.spec.js
test/model/ModelImport.spec.js
test/model/Pagination.spec.js
test/model/Project.spec.js
test/model/ProjectList.spec.js
test/model/Report.spec.js
test/model/ReportList.spec.js
test/model/ReportParameters.spec.js
test/model/Result.spec.js
test/model/ResultList.spec.js
test/model/Run.spec.js
test/model/RunList.spec.js
test/model/WidgetConfig.spec.js
test/model/WidgetConfigList.spec.js
test/model/WidgetParam.spec.js
test/model/WidgetType.spec.js
test/model/WidgetTypeList.spec.js
Removed unused build configuration files
  • Removed .babelrc configuration
  • Removed Mocha options file
.babelrc
mocha.opts

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes - here's some feedback:

  • Please confirm that removing all existing test files is intentional and update the CI/test pipeline accordingly to avoid unexpected failures.
  • Dropping the yarn.lock file may affect reproducible dependency installs—please clarify the intent or provide an updated lockfile if dependencies changed.
  • After deleting .babelrc and mocha.opts, ensure your build and test configurations are updated to use the new TypeScript toolchain.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Please confirm that removing all existing test files is intentional and update the CI/test pipeline accordingly to avoid unexpected failures.
- Dropping the yarn.lock file may affect reproducible dependency installs—please clarify the intent or provide an updated lockfile if dependencies changed.
- After deleting .babelrc and mocha.opts, ensure your build and test configurations are updated to use the new TypeScript toolchain.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes obsolete JavaScript-based test infrastructure and unused dependencies following a migration to TypeScript. The changes clean up legacy test files, Babel configuration, and npm packages that are no longer needed in the TypeScript-based project.

  • Removes all auto-generated OpenAPI test files (model and API spec files)
  • Deletes unused npm dependencies (node-fetch, portable-fetch, encoding, iconv-lite, is-stream, whatwg-fetch, safer-buffer)
  • Removes legacy Babel configuration and Mocha test configuration

Reviewed Changes

Copilot reviewed 37 out of 38 changed files in this pull request and generated no comments.

Show a summary per file
File Description
yarn.lock Removes dependency entries for obsolete packages (node-fetch@1.x, portable-fetch, encoding, iconv-lite, is-stream@1.x, whatwg-fetch, safer-buffer)
test/model/*.spec.js Deletes 27 auto-generated JavaScript model test files
test/api/*.spec.js Deletes 10 auto-generated JavaScript API test files
mocha.opts Removes Mocha test configuration file
.babelrc Removes Babel configuration for JavaScript transpilation

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mshriver mshriver merged commit 6b8df5f into main Nov 5, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants