Typescript Cleanup#6
Merged
Merged
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideRemoved legacy JavaScript test suites and obsolete build configuration files now redundant after migrating to TypeScript. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey there - I've reviewed your changes - here's some feedback:
- Please confirm that removing all existing test files is intentional and update the CI/test pipeline accordingly to avoid unexpected failures.
- Dropping the yarn.lock file may affect reproducible dependency installs—please clarify the intent or provide an updated lockfile if dependencies changed.
- After deleting .babelrc and mocha.opts, ensure your build and test configurations are updated to use the new TypeScript toolchain.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Please confirm that removing all existing test files is intentional and update the CI/test pipeline accordingly to avoid unexpected failures.
- Dropping the yarn.lock file may affect reproducible dependency installs—please clarify the intent or provide an updated lockfile if dependencies changed.
- After deleting .babelrc and mocha.opts, ensure your build and test configurations are updated to use the new TypeScript toolchain.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes obsolete JavaScript-based test infrastructure and unused dependencies following a migration to TypeScript. The changes clean up legacy test files, Babel configuration, and npm packages that are no longer needed in the TypeScript-based project.
- Removes all auto-generated OpenAPI test files (model and API spec files)
- Deletes unused npm dependencies (node-fetch, portable-fetch, encoding, iconv-lite, is-stream, whatwg-fetch, safer-buffer)
- Removes legacy Babel configuration and Mocha test configuration
Reviewed Changes
Copilot reviewed 37 out of 38 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| yarn.lock | Removes dependency entries for obsolete packages (node-fetch@1.x, portable-fetch, encoding, iconv-lite, is-stream@1.x, whatwg-fetch, safer-buffer) |
| test/model/*.spec.js | Deletes 27 auto-generated JavaScript model test files |
| test/api/*.spec.js | Deletes 10 auto-generated JavaScript API test files |
| mocha.opts | Removes Mocha test configuration file |
| .babelrc | Removes Babel configuration for JavaScript transpilation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove unneeded files
Summary by Sourcery
Clean up project by removing obsolete configuration and legacy JavaScript test files
Chores: