-
Notifications
You must be signed in to change notification settings - Fork 159
Open
Labels
lifecycle/confirmedBug is verified or proposal seems reasonableBug is verified or proposal seems reasonable
Description
StackOverflow is currently detected in 3 different ways:
- Hypervisor detects the guest writing to the stack guard page, which host reports as a stackoverflow
- Host checks stack guard canary after guest returns and makes sure it's not modified
- The guest itself somehow identifies a stackoveflow and then aborts with a specific error code, which host reports as a stackoverflow
I believe the third is dead code, as I cannot find anywhere in our code where the guest itself reports this error code. I believe it was previously used when dynamically allocating stack, but not anymore, so we should consider removing this dead code in the host
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
lifecycle/confirmedBug is verified or proposal seems reasonableBug is verified or proposal seems reasonable