Skip to content

Some Implementation deficiencies #1

@TJCoding

Description

@TJCoding

Hi, I am sorry to tell you that the coding for ‘GLO’ doesn’t seem to implement the algorithm in this paper.

https://ieeexplore.ieee.org/document/946629

The paper specifies processing in the Ruderman colour space but the implementation here seems to use the LAB colour space.
This difference can be significant. See for example the discussion here and the accompanying diagram.

https://medium.com/@terence.johnson/a-free-touse-web-app-for-image-colour-transfer-processing-9f5b06c760f4

Some implementations on GitHub purport to implement the Reinhard method but use the CIELab colour space rather than the Ruderman colour space ….. etc, ..... etc

You can find a C++ implementation of the Ruderman forward and inverse transforms in the 'Main.cpp' code here. (‘IMPLEMENTATION OF L-ALPHA-BETA FORWARD AND INVERSE TRANSFORMS’)

https://github.com/TJCoding/Enhanced-Image-Colour-Transfer-2

As you can see from the referenced Github repository, I have a C++ implementation of an ‘Enhanced Reinhard method’. I hope one day to produce a Python version of this. If I do, can I assume that you will give serious consideration to including it in your library?

Please note too that the method cited as ‘Color transfer in correlated space’ (CCS) is not robust. You can find more details at the following links.

https://github.com/hangong/Xiao06_color_transfer
https://github.com/TJCoding/Ruggedised-Image-Colour-Transfer

It should be a relatively simple matter to ruggedize your implementation although you would then need to cross reference myself as well as the original authors.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions