Reconsider default redirect code

[cllns]

Our default redirect is 301: Moved Permanently

https://github.com/hanami/router/blob/50826c98fa9c98ab9a1bfd1de7c99e35370b42e7/lib/hanami/router.rb#L710

In browsers, this is often cached and it can be hard to break that cache. I think we should consider switching our default to 302: Found, which is a temporary redirect.

This is a breaking change so it'd have to be for a 3.0 release. The other option would be to keep 301 as the unconfigured default, then make this a configurable value, then generate new apps with the configuration set. But that seems like a lot of work for something so minor.

[timriley]

@cllns Thanks for raising this. I agree on this being better as 302.

I wonder if we have some wriggle room here. Changing to from 301 to 302 wouldn't strictly break anything — the redirect would still occur, just with a different code, which could be easily enough changed back by the user. We can document this clearly in changelogs and/or upgrade notes. In these early stages of 2.x, I think it's sensible to make little course corrections like this where we can. What do you think?

[cllns]

Yea that's a good point. It has SEO and caching implications, which are important but not mission-critical in terms of breaking an app.

[cllns]

Added #help-wanted. Whoever open this PR, feel free to request a code review from me :)

[svoop]

Just changing the default might not really fix this problem which is the ambiguous nature of the term "redirect" in this context.

A possible alternative might be adding two new methods:

• permanent_redirect (301)
• temporary_redirect (302)

This way, users can choose whether they prefer these explicit methods (which don't accept a code argument) thus making both intentions and implications clear. Or whether they want to stick to the generic redirect.

Also, if this behavior change is done in two steps (step 1: adding the above, later step 2: default redirect to 302), this wouldn't be as disruptive anymore: You've been been warned on step 1 and even if you slept through it, your redirects going from 301 to 302 in step 2 can be easily reverted (unlike the other way around).

[inouire]

Thanks for the tag "help-wanted", I might be able to work on it this month, I'll let you know

[cllns]

I like the idea of permanent_redirect and temporary_redirect, thanks for suggesting it @svoop.

Then we can consider deprecating redirect when called without status (and eventually require it). I think keeping around redirect with status: is a good idea, as well as promoting using the more verbose options