plan: agent sandbox intuitive workspace paths across isolation modes#59
Open
hachej wants to merge 1 commit into
Open
plan: agent sandbox intuitive workspace paths across isolation modes#59hachej wants to merge 1 commit into
hachej wants to merge 1 commit into
Conversation
2a38dbf to
a4545a3
Compare
a4545a3 to
d9dcd87
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plan: make agent sandbox workspace paths intuitive across isolation modes
Introduces a first-class
WorkspacePathMappingabstraction sodirect,local/bwrap, andvercel-sandboxmodes all produce correct runtime-visible paths. No core code hardcodes/workspaceor infers paths from sandbox presence checks.TL;DR
WorkspacePathMappingtype withruntimeWorkspaceRoot, nullablehostWorkspaceRoot, andtoHostPath()/toRuntimePath()translation methods.venv/.boring-agentBORING_AGENT_WORKSPACE_ROOT,VIRTUAL_ENV) from mapping + model-visible cwd together (no split reality)--copies, runtime-aware validation, Vercel venv transfer)Review artifacts
8 review passes included:
/workspace-vs-direct clarificationRemaining before implementation
collectEnv()URL fix, branded path types, matrix test suite)