From 119cebf17b06a2282db4cbeae62a415ff5f1a6c6 Mon Sep 17 00:00:00 2001 From: Riccardo Perotti Date: Fri, 17 Apr 2026 09:23:41 -0400 Subject: [PATCH 1/3] Log GetClient errors with proxy identity and connspec Errors from GetClient() in the service proxy loop were silently discarded due to := scoping, causing 'not found: %!s()' in error messages with no diagnostic information. Now logs each failure with the proxy ident and connspec, and propagates the last error to the outer scope so the 'not found' message includes the actual cause. JiraID: ROP-9188 Co-Authored-By: Claude Sonnet 4.6 --- scamp/requester.go | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/scamp/requester.go b/scamp/requester.go index fc99764..d04fd42 100644 --- a/scamp/requester.go +++ b/scamp/requester.go @@ -47,8 +47,14 @@ func MakeJSONRequest( var clients []*Client for _, serviceProxy := range serviceProxies { if serviceProxy != nil { - client, err := serviceProxy.GetClient() - if err != nil || client == nil { + client, clientErr := serviceProxy.GetClient() + if clientErr != nil { + Error.Printf("GetClient failed for %s (%s): %s", serviceProxy.Ident(), serviceProxy.ConnSpec(), clientErr) + err = clientErr + continue + } + if client == nil { + Error.Printf("GetClient returned nil client for %s (%s)", serviceProxy.Ident(), serviceProxy.ConnSpec()) continue } From 1ae06636c52e9ff9c5856183574d97c69a4ffa20 Mon Sep 17 00:00:00 2001 From: Riccardo Perotti Date: Fri, 17 Apr 2026 09:30:50 -0400 Subject: [PATCH 2/3] Replace stale CircleCI config with GitHub Actions workflow The CircleCI config was using Go 1.10.3 and dep (both long deprecated) and the deploy key was no longer valid. Replace with a GitHub Actions workflow using Go 1.26 that runs go build and go vet. Tests are omitted from CI as they require live SCAMP infrastructure (/etc/SCAMP/soa.conf) that is not available in GitHub Actions runners. JiraID: ROP-9188 Co-Authored-By: Claude Sonnet 4.6 --- .circleci/config.yml | 21 --------------------- .github/workflows/build.yml | 17 +++++++++++++++++ 2 files changed, 17 insertions(+), 21 deletions(-) delete mode 100644 .circleci/config.yml create mode 100644 .github/workflows/build.yml diff --git a/.circleci/config.yml b/.circleci/config.yml deleted file mode 100644 index 49f158e..0000000 --- a/.circleci/config.yml +++ /dev/null @@ -1,21 +0,0 @@ -version: 2 - -jobs: - build: - working_directory: /go/src/github.com/gudtech/scamp-go/ - docker: - - image: circleci/golang:1.10.3 - steps: - - checkout - - restore_cache: - key: gopkg-{{ .Branch }}-{{ checksum "./scamp/Gopkg.lock" }} - paths: - - /go/src/github.com/gudtech/scamp-go/scamp/vendor - - run: curl https://raw.githubusercontent.com/golang/dep/master/install.sh | sh - - run: cd ./scamp && dep ensure -vendor-only - - run: cd ./scamp && go build -v - - save_cache: - key: gopkg-{{ .Branch }}-{{ checksum "./scamp/Gopkg.lock" }} - paths: - - /go/src/github.com/gudtech/scamp-go/scamp/vendor - - run: cd ./scamp && go test -v -race ./... \ No newline at end of file diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml new file mode 100644 index 0000000..e4cc11a --- /dev/null +++ b/.github/workflows/build.yml @@ -0,0 +1,17 @@ +name: Build and Vet scamp-go + +on: + push: + +jobs: + build: + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v4 + - uses: actions/setup-go@v5 + with: + go-version: '1.26' + - name: Build + run: go build ./... + - name: Vet + run: go vet ./... From 21e9da47d715651c8ec2e614e33ac29072800f45 Mon Sep 17 00:00:00 2001 From: Riccardo Perotti Date: Fri, 17 Apr 2026 09:40:38 -0400 Subject: [PATCH 3/3] Trigger CI checks