SwiftShader has no PCI bus, so there's nothing to fill in#34
Open
krishnadurai wants to merge 1 commit into
Open
SwiftShader has no PCI bus, so there's nothing to fill in#34krishnadurai wants to merge 1 commit into
krishnadurai wants to merge 1 commit into
Conversation
SwiftShader's vkGetPhysicalDeviceProperties2 aborts in debug builds when encountering VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_PCI_BUS_INFO_PROPERTIES_EXT in the pNext chain. This occurs when the Vulkan loader's linux_read_sorted_physical_devices() queries PCI bus info on all physical devices, including SwiftShader. Per the Vulkan spec (section 3.6.2), drivers must skip over unrecognized pNext members without processing them. SwiftShader is a software renderer with no PCI bus, so the correct behavior is to silently skip this sType. Without this fix, loading SwiftShader alongside a hardware GPU driver (e.g., NVIDIA) crashes in debug builds because UNSUPPORTED() calls sw::abort().
Contributor
|
Hi, this repo is just a mirror of another repo. To contribute to SwiftShader, look at the info here: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SwiftShader's vkGetPhysicalDeviceProperties2 aborts in debug builds when encountering VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_PCI_BUS_INFO_PROPERTIES_EXT in the pNext chain. This occurs when the Vulkan loader's linux_read_sorted_physical_devices() queries PCI bus info on all physical devices, including SwiftShader. Per the Vulkan spec (section 3.6.2), drivers must skip over unrecognized pNext members without processing them. SwiftShader is a software renderer with no PCI bus, so the correct behavior is to silently skip this sType. Without this fix, loading SwiftShader alongside a hardware GPU driver (e.g., NVIDIA) crashes in debug builds because UNSUPPORTED() calls sw::abort().