diff --git a/src/idiomatic/foundations-api-design/predictable-api/naming-conventions/from.md b/src/idiomatic/foundations-api-design/predictable-api/naming-conventions/from.md index cd9dc2501286..d6dec2631cfb 100644 --- a/src/idiomatic/foundations-api-design/predictable-api/naming-conventions/from.md +++ b/src/idiomatic/foundations-api-design/predictable-api/naming-conventions/from.md @@ -31,11 +31,8 @@ impl u32 {
- Prefix for constructor-style, `From`-trait-style functions. -- These functions can take multiple arguments, but usually imply the user is - doing more of the work than a usual constructor would. - - `new` is still preferred for most constructor-style functions, the implication - for `from` is transformation of one data type to another. +- `new` is preferred for constructor-style functions, the implication for `from` + is transformation of one data type to another. - Ask: Without looking at the standard library documentation, what would the argument type of `u32::from_be` be? diff --git a/src/idiomatic/foundations-api-design/predictable-api/naming-conventions/get.md b/src/idiomatic/foundations-api-design/predictable-api/naming-conventions/get.md index 2e4bdc1cd890..08e2d9986bad 100644 --- a/src/idiomatic/foundations-api-design/predictable-api/naming-conventions/get.md +++ b/src/idiomatic/foundations-api-design/predictable-api/naming-conventions/get.md @@ -19,7 +19,7 @@ impl OnceCell {
- Gets are trivial, they get a value! -Immutable by default, for the most part. +Immutable by default. Should not panic. May return an option or result, depending on the framework.