From 81f0b7ab0f9c855c6633d6e5f92408f6b503a4d3 Mon Sep 17 00:00:00 2001 From: Seth Vargo Date: Tue, 2 Sep 2025 21:53:17 -0400 Subject: [PATCH] Bump to Node 24 --- .github/actionlint.yml | 5 +++++ .github/workflows/integration.yml | 2 +- README.md | 12 ++++++------ action.yml | 4 ++-- bin/runTests.sh | 21 --------------------- package-lock.json | 14 +++++++------- package.json | 6 +++--- 7 files changed, 24 insertions(+), 40 deletions(-) delete mode 100644 bin/runTests.sh diff --git a/.github/actionlint.yml b/.github/actionlint.yml index a7eeed2..a0a63d4 100644 --- a/.github/actionlint.yml +++ b/.github/actionlint.yml @@ -1,4 +1,9 @@ paths: + '**/*.yml': + ignore: + # https://github.com/rhysd/actionlint/issues/559 + - 'invalid runner name "node24"' + '.github/workflows/integration.yml': ignore: - 'property ".+" is not defined in object type' diff --git a/.github/workflows/integration.yml b/.github/workflows/integration.yml index 4a6a17c..76dd20c 100644 --- a/.github/workflows/integration.yml +++ b/.github/workflows/integration.yml @@ -37,7 +37,7 @@ jobs: - name: 'npm build' run: 'npm ci && npm run build' - - uses: 'google-github-actions/auth@v2' # ratchet:exclude + - uses: 'google-github-actions/auth@v3' # ratchet:exclude with: workload_identity_provider: '${{ vars.WIF_PROVIDER_NAME }}' service_account: '${{ vars.SERVICE_ACCOUNT_EMAIL }}' diff --git a/README.md b/README.md index 45a5eb7..69819ec 100644 --- a/README.md +++ b/README.md @@ -38,13 +38,13 @@ jobs: steps: - id: 'auth' - uses: 'google-github-actions/auth@v2' + uses: 'google-github-actions/auth@v3' with: workload_identity_provider: 'projects/123456789/locations/global/workloadIdentityPools/my-pool/providers/my-provider' service_account: 'my-service-account@my-project.iam.gserviceaccount.com' - id: 'secrets' - uses: 'google-github-actions/get-secretmanager-secrets@v2' + uses: 'google-github-actions/get-secretmanager-secrets@v3' with: secrets: |- token:my-project/docker-registry-token @@ -124,7 +124,7 @@ jobs: job_id: steps: - id: 'secrets' - uses: 'google-github-actions/get-secretmanager-secrets@v2' + uses: 'google-github-actions/get-secretmanager-secrets@v3' with: secrets: |- token:my-project/docker-registry-token @@ -162,13 +162,13 @@ jobs: - uses: 'actions/checkout@v4' - id: 'auth' - uses: 'google-github-actions/auth@v2' + uses: 'google-github-actions/auth@v3' with: workload_identity_provider: 'projects/123456789/locations/global/workloadIdentityPools/my-pool/providers/my-provider' service_account: 'my-service-account@my-project.iam.gserviceaccount.com' - id: 'secrets' - uses: 'google-github-actions/get-secretmanager-secrets@v2' + uses: 'google-github-actions/get-secretmanager-secrets@v3' ``` ### Via Application Default Credentials @@ -183,7 +183,7 @@ jobs: job_id: steps: - id: 'secrets' - uses: 'google-github-actions/get-secretmanager-secrets@v2' + uses: 'google-github-actions/get-secretmanager-secrets@v3' ``` The action will automatically detect and use the Application Default diff --git a/action.yml b/action.yml index b15ecb4..9e30e6d 100644 --- a/action.yml +++ b/action.yml @@ -96,7 +96,7 @@ outputs: job_id: steps: - id: 'secrets' - uses: 'google-github-actions/get-secretmanager-secrets@v2' + uses: 'google-github-actions/get-secretmanager-secrets@v3' with: secrets: |- token:my-project/docker-registry-token @@ -113,5 +113,5 @@ branding: color: 'blue' runs: - using: 'node20' + using: 'node24' main: 'dist/main/index.js' diff --git a/bin/runTests.sh b/bin/runTests.sh deleted file mode 100644 index c47d2f8..0000000 --- a/bin/runTests.sh +++ /dev/null @@ -1,21 +0,0 @@ -#!/usr/bin/env bash -set -eEuo pipefail - -# -# As of Node 20, the --test parameter does not support globbing, and it does not -# support variable Windows paths. We also cannot invoke the test runner -# directly, because while it has an API, there's no way to force it to transpile -# the Typescript into JavaScript before passing it to the runner. -# -# So we're left with this solution, which shells out to Node to list all files -# that end in *.test.ts (excluding node_modules/), and then execs out to that -# process. We have to exec so the stderr/stdout and exit code is appropriately -# fed to the caller. -# - -FILES="$(node -e "process.stdout.write(require('node:fs').readdirSync('./', { recursive: true }).filter((e) => {return e.endsWith('.test.ts') && !e.startsWith('node_modules');}).sort().join(' '));")" - -set -x - -# shellcheck disable=SC2086 -exec node --require ts-node/register --test-reporter spec --test ${FILES} diff --git a/package-lock.json b/package-lock.json index 8bca087..6f3b115 100644 --- a/package-lock.json +++ b/package-lock.json @@ -11,7 +11,7 @@ "dependencies": { "@actions/core": "^1.11.1", "@actions/http-client": "^2.2.3", - "@google-github-actions/actions-utils": "^0.8.10", + "@google-github-actions/actions-utils": "^1.0.1", "google-auth-library": "^10.1.0" }, "devDependencies": { @@ -30,7 +30,7 @@ "typescript-eslint": "^8.37.0" }, "engines": { - "node": ">= 20.x", + "node": ">= 24.x", "npm": ">= 11.x" } }, @@ -220,9 +220,9 @@ } }, "node_modules/@google-github-actions/actions-utils": { - "version": "0.8.10", - "resolved": "https://registry.npmjs.org/@google-github-actions/actions-utils/-/actions-utils-0.8.10.tgz", - "integrity": "sha512-NLmKwQgPj0cQyDjbtQIGUYBdPtFIywLbH10RPRuhF6tO7qlO19N76SsaDEiZ7iKlXA9Yfj8TS3lK6wfdJyE+hw==", + "version": "1.0.1", + "resolved": "https://registry.npmjs.org/@google-github-actions/actions-utils/-/actions-utils-1.0.1.tgz", + "integrity": "sha512-dEvNcy63a6pkcMsRhWbfjNePsv4kR61O56mQ9rVXvRgjAvRkZTBiM1G7QSnHulMEjhLIlTEGlBIKEKIxCoonkQ==", "license": "Apache-2.0", "dependencies": { "yaml": "^2.8.1" @@ -231,8 +231,8 @@ "actions-gen-readme": "bin/actions-gen-readme.mjs" }, "engines": { - "node": ">= 20.x", - "npm": ">= 10.x" + "node": ">= 24.x", + "npm": ">= 11.x" } }, "node_modules/@humanfs/core": { diff --git a/package.json b/package.json index c5c144d..b15a62f 100644 --- a/package.json +++ b/package.json @@ -8,10 +8,10 @@ "docs": "./node_modules/.bin/actions-gen-readme", "lint": "eslint .", "format": "eslint . --fix", - "test": "bash ./bin/runTests.sh" + "test": "node --require ts-node/register --test-reporter spec --test tests/**/*.test.ts" }, "engines": { - "node": ">= 20.x", + "node": ">= 24.x", "npm": ">= 11.x" }, "repository": { @@ -29,7 +29,7 @@ "dependencies": { "@actions/core": "^1.11.1", "@actions/http-client": "^2.2.3", - "@google-github-actions/actions-utils": "^0.8.10", + "@google-github-actions/actions-utils": "^1.0.1", "google-auth-library": "^10.1.0" }, "devDependencies": {