Don't write buffers section if buffer is empty#59
Open
danwillm wants to merge 2 commits into
Open
Conversation
fire
reviewed
Jul 1, 2024
Author
|
Hey, anything else you'd like me to resolve for this to be merged? |
Member
|
I haven't had much testing of this since in Godot 4.3 we switched to ufbx. I'll merge and it'll generate builds. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have an fbx file that when procced through FBX2gLTF produced the buffers json segment as:
Which is not valid in gltf. Instead, omit this from being written to the file by only writing non-empty json.