From 0e0541bf164d5636626cdc31026001cd060ab6b9 Mon Sep 17 00:00:00 2001
From: mgabor3141 <9047995+mgabor3141@users.noreply.github.com>
Date: Sat, 4 Apr 2026 19:37:02 +0200
Subject: [PATCH] fix: remove forwardPorts/portsAttributes from feature JSON

The devcontainer feature schema (devcontainer-feature.json) doesn't
allow forwardPorts or portsAttributes. These are devcontainer.json
properties that users add to their own config. The publish action
validates against the schema and rejects them.

Move the port forwarding config into the README examples instead.
---
 README.md                          | 3 ++-
 src/gmux/README.md                 | 7 ++++++-
 src/gmux/devcontainer-feature.json | 7 -------
 3 files changed, 8 insertions(+), 9 deletions(-)

diff --git a/README.md b/README.md
index 957b06c..85cd37a 100644
--- a/README.md
+++ b/README.md
@@ -13,7 +13,8 @@ Installs gmux and gmuxd into a dev container. gmuxd starts automatically when th
   "image": "mcr.microsoft.com/devcontainers/base:debian",
   "features": {
     "ghcr.io/gmuxapp/features/gmux:1": {}
-  }
+  },
+  "forwardPorts": [8790]
 }
 ```
 
diff --git a/src/gmux/README.md b/src/gmux/README.md
index 244cc8d..539574c 100644
--- a/src/gmux/README.md
+++ b/src/gmux/README.md
@@ -9,11 +9,15 @@ Installs [gmux](https://gmux.app) and gmuxd into a dev container. gmuxd starts a
   "image": "mcr.microsoft.com/devcontainers/base:debian",
   "features": {
     "ghcr.io/gmuxapp/features/gmux:1": {}
+  },
+  "forwardPorts": [8790],
+  "portsAttributes": {
+    "8790": { "label": "gmux", "onAutoForward": "silent" }
   }
 }
 ```
 
-Port 8790 is automatically forwarded to the host. Open the forwarded URL and authenticate with the bearer token.
+Add `forwardPorts` to your `devcontainer.json` so port 8790 is forwarded to the host. Open the forwarded URL and authenticate with the bearer token.
 
 ### Finding the auth token
 
@@ -39,6 +43,7 @@ If you need a known token (for scripting, health checks, or future host-side pee
   "features": {
     "ghcr.io/gmuxapp/features/gmux:1": {}
   },
+  "forwardPorts": [8790],
   "containerEnv": {
     "GMUXD_TOKEN": "output-of-openssl-rand-hex-32"
   }
diff --git a/src/gmux/devcontainer-feature.json b/src/gmux/devcontainer-feature.json
index 05120cd..ebf7ecb 100644
--- a/src/gmux/devcontainer-feature.json
+++ b/src/gmux/devcontainer-feature.json
@@ -14,12 +14,5 @@
   "containerEnv": {
     "GMUXD_LISTEN": "0.0.0.0"
   },
-  "forwardPorts": [8790],
-  "portsAttributes": {
-    "8790": {
-      "label": "gmux",
-      "onAutoForward": "silent"
-    }
-  },
   "entrypoint": "/usr/local/bin/gmuxd-start.sh"
 }