test: clean up dotnet signal test assertions and comments

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: jpnurmi

tests/fixtures/dotnet_signal/Platforms/Android/MainActivity.cs

@@ -18,8 +18,8 @@ protected override void OnResume()
         {
             var databasePath = FilesDir?.AbsolutePath + "/.sentry-native";
 
-            // Post the test to the main thread's message queue so it runs
-            // after OnResume returns and the activity is fully started.
+            // Post to the message queue so the activity finishes starting
+            // before the crash test runs. Without this, "am start -W" may hang.
             new Handler(Looper.MainLooper!).Post(() =>
             {
                 Program.RunTest(new[] { arg }, databasePath);

tests/test_dotnet_signals.py

@@ -102,11 +102,9 @@ def test_dotnet_signals_inproc(cmake):
         dotnet_run_stdout, dotnet_run_stderr = dotnet_run.communicate()
 
         # the program handles the `NullReferenceException`, so the Native SDK won't register a crash.
-        assert (
-            dotnet_run.returncode == 0
-        ), f"Managed exception run failed.\nstdout:\n{dotnet_run_stdout}\nstderr:\n{dotnet_run_stderr}"
-        assert (
-            "NullReferenceException" not in dotnet_run_stderr
+        assert dotnet_run.returncode == 0
+        assert not (
+            "NullReferenceException" in dotnet_run_stderr
         ), f"Managed exception run failed.\nstdout:\n{dotnet_run_stdout}\nstderr:\n{dotnet_run_stderr}"
         database_path = project_fixture_path / ".sentry-native"
         assert database_path.exists(), "No database-path exists"
@@ -223,11 +221,9 @@ def test_aot_signals_inproc(cmake):
         dotnet_run_stdout, dotnet_run_stderr = dotnet_run.communicate()
 
         # the program handles the `NullReferenceException`, so the Native SDK won't register a crash.
-        assert (
-            dotnet_run.returncode == 0
-        ), f"Managed exception run failed.\nstdout:\n{dotnet_run_stdout}\nstderr:\n{dotnet_run_stderr}"
-        assert (
-            "NullReferenceException" not in dotnet_run_stderr
+        assert dotnet_run.returncode == 0
+        assert not (
+            "NullReferenceException" in dotnet_run_stderr
         ), f"Managed exception run failed.\nstdout:\n{dotnet_run_stdout}\nstderr:\n{dotnet_run_stderr}"
         database_path = tmp_path / ".sentry-native"
         assert database_path.exists(), "No database-path exists"
@@ -425,36 +421,27 @@ def has_envelope():
 
         # managed exception: handled, no crash
         logcat = run_android_managed_exception()
-        print("=== managed exception logcat ===\n", logcat)
-        assert (
-            "NullReferenceException" not in logcat
-        ), "Managed exception leaked.\nlogcat:\n{}".format(logcat)
-        assert wait_for(
-            lambda: dir_exists(db)
-        ), "No database-path exists.\nlogcat:\n{}".format(logcat)
+        assert not (
+            "NullReferenceException" in logcat
+        ), f"Managed exception leaked.\nlogcat:\n{logcat}"
+        assert wait_for(lambda: dir_exists(db)), "No database-path exists"
         assert not file_exists(db + "/last_crash"), "A crash was registered"
         assert not has_envelope(), "Unexpected envelope found"
 
         # unhandled managed exception: Mono calls exit(1), the native SDK
         # should not register a crash (sentry-dotnet handles this at the
         # managed layer via UnhandledExceptionRaiser)
         logcat = run_android_unhandled_managed_exception()
-        print("=== unhandled managed exception logcat ===\n", logcat)
         assert (
             "NullReferenceException" in logcat
-        ), "Expected NullReferenceException.\nlogcat:\n{}".format(logcat)
-        assert wait_for(
-            lambda: dir_exists(db)
-        ), "No database-path exists.\nlogcat:\n{}".format(logcat)
+        ), f"Expected NullReferenceException.\nlogcat:\n{logcat}"
+        assert wait_for(lambda: dir_exists(db)), "No database-path exists"
         assert not file_exists(db + "/last_crash"), "A crash was registered"
         assert not has_envelope(), "Unexpected envelope found"
 
         # native crash
-        logcat = run_android_native_crash()
-        print("=== native crash logcat ===\n", logcat)
-        assert wait_for(
-            lambda: file_exists(db + "/last_crash")
-        ), "Crash marker missing.\nlogcat:\n{}".format(logcat)
+        run_android_native_crash()
+        assert wait_for(lambda: file_exists(db + "/last_crash")), "Crash marker missing"
         assert wait_for(has_envelope), "Crash envelope is missing"
 
     finally: