000 - fix invalid array index

vb-c-plicity · ppavlovic · commit 3117fdac6ad7 · 2024-08-09T15:55:50.000+02:00
(cherry picked from commit f7574c4)
diff --git a/src/Probability.php b/src/Probability.php
@@ -40,7 +40,8 @@ public static function isValid($value)
      */
     public static function generateRandomWithChance()
     {
-        return new static(rand(self::MINIMAL_CHANCE, self::CERTAIN));
+        //$chances array, in getOutcome(), starts from index 0, and random can be from 1 to 100;
+        return new static(rand(self::MINIMAL_CHANCE, self::CERTAIN) - 1);
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -40,7 +40,8 @@ public static function isValid($value)`
`40`	`40`	`*/`
`41`	`41`	`public static function generateRandomWithChance()`
`42`	`42`	`{`
`43`		`- return new static(rand(self::MINIMAL_CHANCE, self::CERTAIN));`
	`43`	`+ //$chances array, in getOutcome(), starts from index 0, and random can be from 1 to 100;`
	`44`	`+ return new static(rand(self::MINIMAL_CHANCE, self::CERTAIN) - 1);`
`44`	`45`	`}`
`45`	`46`
`46`	`47`	`/**`