Merge pull request #62 from mirko-bukilic/master

Updated FieldsTruncator

Author: ppavlovic

src/Buffer/FieldsTruncator.php

@@ -77,7 +77,7 @@ private function truncateValue(string $fieldName, $value)
     public function shouldTruncateField(string $fieldName): bool
     {
         if (!isset($this->config[$this->logType])) {
-            return true;
+            return false;
         }
         return in_array($fieldName, $this->config[$this->logType], true);
     }

test/src/Buffer/FieldsTruncatorTest.php

@@ -15,9 +15,15 @@ protected function setUp(): void
             'enabled' => 1,
             'truncate_above' => 100,
             'truncate_to' => 50,
+            'nd_test' => [
+                'app_message',
+                'code',
+                'params',
+            ],
             'nd_requests' => [
                 'resource',
                 'params',
+                'profiler',
             ],
         ];
     }
@@ -38,9 +44,19 @@ public function testShouldTruncateField(): void
         $fieldsTruncator = new FieldsTruncator(new StringLiteral('nd_requests'), $this->config);
         self::assertTrue($fieldsTruncator->shouldTruncateField('resource'));
         self::assertTrue($fieldsTruncator->shouldTruncateField('params'));
+        self::assertTrue($fieldsTruncator->shouldTruncateField('profiler'));
         self::assertFalse($fieldsTruncator->shouldTruncateField('app_message'));
     }
 
+    /**
+     * @dataProvider truncateDataProvider
+     */
+    public function testTruncateField(string $indexName, string $fieldName, bool $expectedResult): void
+    {
+        $truncator = new FieldsTruncator(new StringLiteral($indexName), $this->config);
+        self::assertSame($expectedResult, $truncator->shouldTruncateField($fieldName));
+    }
+
     public function testTruncate(): void
     {
         $fieldsTruncator = new FieldsTruncator(new StringLiteral('nd_requests'), $this->config);
@@ -63,4 +79,27 @@ public function testTruncate(): void
 
         self::assertSame($expected, $fieldsTruncator->truncate($logData));
     }
+
+    public function truncateDataProvider(): array
+    {
+        return [
+            ['nd_requests', 'params', true],
+            ['nd_requests', 'resource', true],
+            ['nd_requests', 'profiler', true],
+            ['nd_requests', 'app_message', false],
+            ['nd_requests', 'app_version', false],
+            ['nd_requests', 'method', false],
+            ['mailer_sent_emails', 'params', false],
+            ['mailer_sent_emails', 'resource', false],
+            ['mailer_sent_emails', 'profiler', false],
+            ['mailer_sent_emails', 'app_message', false],
+            ['mailer_sent_emails', 'app_version', false],
+            ['mailer_sent_emails', 'method', false],
+            ['nd_test', 'profiler', false],
+            ['nd_test', 'resource', false],
+            ['nd_test', 'app_message', true],
+            ['nd_test', 'code', true],
+            ['nd_test', 'params', true],
+        ];
+    }
 }