Since we have excluded frontend folder from triggering the automatic CI build we no longer has anything checking if npm run build works. Because this is triggered by a mvn compile that fails when trying to deploy. To start with we should fix this error. Looks like it's just a line that needs to be removed?
In the long term we should have a ci pipeline that runs npm run build when changes to frontend is detected.
Also can we configure npm to delete unused imports automatically? Is that something bad or good? Can we use eslint-plugin-unused-imports
[INFO] --- frontend:1.15.0:npm (npm-build) @ system2024 ---
[INFO] Running 'npm run build' in C:\Users\marti\IdeaProjects\labb\test\system2024\frontend
[INFO]
[INFO] > system24frontend@0.0.0 build
[INFO] > tsc -b && vite build
[INFO]
[INFO] src/components/common/Header.tsx(4,1): error TS6133: 'MenuItemsMobile' is declared but its value is never read.
Since we have excluded frontend folder from triggering the automatic CI build we no longer has anything checking if npm run build works. Because this is triggered by a mvn compile that fails when trying to deploy. To start with we should fix this error. Looks like it's just a line that needs to be removed?
In the long term we should have a ci pipeline that runs npm run build when changes to frontend is detected.
Also can we configure npm to delete unused imports automatically? Is that something bad or good? Can we use eslint-plugin-unused-imports
[INFO] --- frontend:1.15.0:npm (npm-build) @ system2024 ---
[INFO] Running 'npm run build' in C:\Users\marti\IdeaProjects\labb\test\system2024\frontend
[INFO]
[INFO] > system24frontend@0.0.0 build
[INFO] > tsc -b && vite build
[INFO]
[INFO] src/components/common/Header.tsx(4,1): error TS6133: 'MenuItemsMobile' is declared but its value is never read.