Project feedback

[Haaxor1689]

• You did not modify metadata in index.html from the default vite template
• Declaration in .d.ts should have been added to already existing vite-end.d.ts typings file
• You are importing leaflet/dist/leaflet.css in multiple places around your app, it would have been enough to import in in App.tsx. Also src/leaflet.css is completely unused since you are using styles from the node module.
• There are a ton of unused (and probably conflicting) css rules in index.css and App.css since you are using MUI for styling.
• You could have used the styleOverrides in createTheme instead of using any css files at all since you are using MUI theme.
• The map should have been zoomed in on Brno on load
• Unescaped   in the text. You can for example use the DOMParser to unescape text like this.
• App like this should not have been restricted to this small max-width but should have stretched to full window width.
• Many of the files aren't formatted properly, having extra spaces/tabs/lines, etc.
• Unused src/assets/react.svg in source.
• Try to keep all assets like iconChange.png in assets folder.
• GithubAuthProvider should be initialized only once, putting it inside body of a hook will cause it to be recreated every render.
• You can use a finally block for setting stuff like setIsPending(false) that should be always executed.
• In src/firebase/firebase-config.ts there is really no need for the getFirebaseConfig function since config is completely static variable.
• You are passing setCurrentUser to AuthContext even though it's not used outside of the provider at all.
• There is a random let response: any in MapComponent.tsx
• Try naming your components the same as their file name when default exporting, otherwise, it can be harder to find them properly.
• For every click on a star rating a completely new entry is created in the favorites list, resulting in duplicates.
• Lots of console logs throughout the whole app.

*20