Fix: Correct google stow item url format#17
Merged
Conversation
Signed-off-by: Fabio Graetz <fabiograetz@googlemail.com>
3 tasks
fg91
commented
Dec 17, 2024
| @@ -113,22 +113,34 @@ func (l *Location) RemoveContainer(id string) error { | |||
| // ItemByURL retrieves a stow.Item by parsing the URL, in this | |||
| // case an item is an object. | |||
| func (l *Location) ItemByURL(url *url.URL) (stow.Item, error) { | |||
Member
Author
There was a problem hiding this comment.
Adapting this function was required for google/stow_test.go to pass.
Note that on master and on this branch I needed to disable this check for the test to pass tough: t.Fatalf("Leaked %d TCP file descriptor", diffFDs).
There was a problem hiding this comment.
interesting. Can you paste the error? I'm unable to repro it on a Mac (I also added #18 and all tests pass on linux/amd64 too).
eapolinario
approved these changes
Dec 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For RFC flyteorg/flyte#5598, flytepropeller was given the ability to list error files in the so-called raw output prefix bucket of an execution with the goal of identifying which worker pod in a failed distributed task experienced the first error.
For this purpose, the
StowStorein flytestdlib was given aListfunction.For google cloud storage buckets, the listing and subsequent access of the error files currently does not work: When listing a bucket
gs://some-bucket/..., one receives items in the formgoogle://storage.googleapis.com/download/storage/v1/b/some-bucket/...which then cannot be found by the stow store for thegs://prefix.This PR fixes the URL format in the underlying stow library.