refactor: replace serialize with pack on primivite values

Author: norberttech

src/lib/parquet/src/Flow/Parquet/ParquetFile/Data/Converter/Int64DateTimeConverter.php

@@ -4,7 +4,6 @@
 
 namespace Flow\Parquet\ParquetFile\Data\Converter;
 
-use function Flow\Types\DSL\{type_instance_of, type_integer};
 use Flow\Parquet\Options;
 use Flow\Parquet\ParquetFile\Data\Converter;
 use Flow\Parquet\ParquetFile\Schema\{FlatColumn, LogicalType, PhysicalType};
@@ -13,7 +12,8 @@ final class Int64DateTimeConverter implements Converter
 {
     public function fromParquetType(mixed $data) : \DateTimeImmutable
     {
-        return $this->microsecondsToDateTimeImmutable(type_integer()->assert($data));
+        /** @var int $data */
+        return new \DateTimeImmutable('@' . \number_format($data / 1_000_000, 6, '.', ''));
     }
 
     public function isFor(FlatColumn $column, Options $options) : bool
@@ -27,16 +27,7 @@ public function isFor(FlatColumn $column, Options $options) : bool
 
     public function toParquetType(mixed $data) : int
     {
-        return $this->dateTimeToMicroseconds(type_instance_of(\DateTimeInterface::class)->assert($data));
-    }
-
-    private function dateTimeToMicroseconds(\DateTimeInterface $dateTime) : int
-    {
-        return (int) \bcadd(\bcmul($dateTime->format('U'), '1000000'), $dateTime->format('u'));
-    }
-
-    private function microsecondsToDateTimeImmutable(int $microseconds) : \DateTimeImmutable
-    {
-        return new \DateTimeImmutable('@' . \number_format($microseconds / 1_000_000, 6, '.', ''));
+        /** @var \DateTimeInterface $data */
+        return $data->getTimestamp() * 1_000_000 + (int) $data->format('u');
     }
 }

src/lib/parquet/src/Flow/Parquet/Writer/PageBuilder/DictionaryBuilder/FloatDictionaryBuilder.php

@@ -21,21 +21,17 @@ public function build(WriteFlatColumnValues $data) : Dictionary
                 continue;
             }
 
-            $hash = \serialize($value);
+            $hash = \pack('E', $value);
 
             if (!isset($valueToIndex[$hash])) {
-                $dictionary[] = $hash;
+                $dictionary[] = $value;
                 $valueToIndex[$hash] = $dictionarySize;
                 $dictionarySize++;
             }
 
             $indices[] = $valueToIndex[$hash];
         }
 
-        foreach ($dictionary as $index => $value) {
-            $dictionary[$index] = @\unserialize($value, ['allowed_classes' => []]);
-        }
-
         return new Dictionary($dictionary, $indices);
     }
 }

src/lib/parquet/src/Flow/Parquet/Writer/PageBuilder/DictionaryBuilder/ObjectDictionaryBuilder.php

@@ -21,21 +21,21 @@ public function build(WriteFlatColumnValues $data) : Dictionary
                 continue;
             }
 
-            $hash = \serialize($value);
+            if ($value instanceof \DateTimeInterface) {
+                $hash = $value->format('U u');
+            } else {
+                $hash = \serialize($value);
+            }
 
             if (!isset($valueToIndex[$hash])) {
-                $dictionary[] = $hash;
+                $dictionary[] = $value;
                 $valueToIndex[$hash] = $dictionarySize;
                 $dictionarySize++;
             }
 
             $indices[] = $valueToIndex[$hash];
         }
 
-        foreach ($dictionary as $index => $value) {
-            $dictionary[$index] = @\unserialize($value, ['allowed_classes' => [\DateTimeImmutable::class, \DateInterval::class]]);
-        }
-
         return new Dictionary($dictionary, $indices);
     }
 }

src/lib/parquet/src/Flow/Parquet/Writer/PageBuilder/DictionaryBuilder/ScalarDictionaryBuilder.php

@@ -22,7 +22,7 @@ public function build(WriteFlatColumnValues $data) : Dictionary
             }
 
             if (\is_float($value)) {
-                $key = \serialize($value);
+                $key = \pack('E', $value);
             } else {
                 $key = $value;
             }
@@ -36,10 +36,6 @@ public function build(WriteFlatColumnValues $data) : Dictionary
             $indices[] = $valueToIndex[$key];
         }
 
-        foreach ($dictionary as $index => $value) {
-            $dictionary[$index] = $value;
-        }
-
         return new Dictionary($dictionary, $indices);
     }
 }