Pushes in the 'error' category don't render in the admin UI unless a diff was produced

[kriswest]

Describe the bug
Pushes that end up in the error category can't be viewed in the admin UI if the diff step failed:

"lastStep": {
    "logs": [
      "diff - Executing \"git diff c338e9a0035b755f4f5c6fff00fa8b8f206d8c05 cee0c02d1cb4c22a7f014b370f00f83868a7c746\" in ./.remote/0000000000000000000000000000000000000000__cee0c02d1cb4c22a7f014b370f00f83868a7c746/fdc3.git",
      "diff - Error: fatal: Invalid revision range c338e9a0035b755f4f5c6fff00fa8b8f206d8c05..cee0c02d1cb4c22a7f014b370f00f83868a7c746\n"
    ],
    "id": "c5d80af9-465d-4e75-8d2a-47300261c034",
    "stepName": "diff",
    "content": null,
    "error": true,
    "errorMessage": "Error: fatal: Invalid revision range c338e9a0035b755f4f5c6fff00fa8b8f206d8c05..cee0c02d1cb4c22a7f014b370f00f83868a7c746\n",
    "blocked": false,
    "blockedMessage": null
  }

This results in a white screen with no UI rendered.

To Reproduce

• Create a branch where the base is not in the upstream repo (e.g. create a branch, add some commits to it, then create a new branch from it, add commits to that and then try to push the result to the proxy)
• The proxy should reject the push, but add it to the error tab in the dashboard
• Attempt to view the diff.

Expected behavior
Details of the push should be displayed, including the error message, but with no Diff.

[kriswest]

@andypols I suspect you may not have come across this yet. I'm hitting it periodically as we have internal forks of projects and every now and then someone tries to push a branch whose base is not in the upstream repo (at least I think thats the cause).

The solution is probably as simple as checking that push.diff is set before rendering the Diff tag:

git-proxy/src/ui/views/PushDetails/PushDetails.tsx

Line 325 in a78b4f2

<Diff diff={push.diff.content} />

However, it might also be useful to render the log messages/error message so we know why it failed - I have a feeling you might have looked at that?

[andypols]

@kriswest interesting I have not seen that. We have been experimenting with a slightly different viewer which may account for this.

We show an

• An ai generated summary of the change
• the commits
• the diff
• and a summary of the actions in the chain (lists the status, log messages for each action).

So there is always something to show even when the it fails to generate a diff.

I can try and extract some PRs around this. The action summary is really useful in working out what has gone wrong. The AI summary is helpful, but can't be implemented as a plugin using the current architecture as it needs change the UI.

[kriswest]

The action summary sounds really useful!