From 4671c22c71fbd3a595bf277d64f5242b95e79480 Mon Sep 17 00:00:00 2001
From: gaurav <721466+soodoku@users.noreply.github.com>
Date: Sun, 17 Aug 2025 12:53:03 -0700
Subject: [PATCH] Add tests for kernel bandwidth derivatives and optimization

---
 tests/__init__.py         |   0
 tests/test_derivatives.py |  21 ++++++++
 tests/test_newton.py      |  26 +++++++++
 tests/utils.py            | 111 ++++++++++++++++++++++++++++++++++++++
 4 files changed, 158 insertions(+)
 create mode 100644 tests/__init__.py
 create mode 100644 tests/test_derivatives.py
 create mode 100644 tests/test_newton.py
 create mode 100644 tests/utils.py

diff --git a/tests/__init__.py b/tests/__init__.py
new file mode 100644
index 0000000..e69de29
diff --git a/tests/test_derivatives.py b/tests/test_derivatives.py
new file mode 100644
index 0000000..ecda429
--- /dev/null
+++ b/tests/test_derivatives.py
@@ -0,0 +1,21 @@
+import random
+import math
+from .utils import lscv_generic
+
+
+def finite_diff(f, h, eps=1e-5):
+    f_plus = f(h + eps)
+    f_minus = f(h - eps)
+    grad = (f_plus - f_minus) / (2 * eps)
+    hess = (f_plus - 2 * f(h) + f_minus) / (eps ** 2)
+    return grad, hess
+
+
+def test_lscv_derivatives_against_finite_diff():
+    rng = random.Random(0)
+    x = [rng.gauss(0, 1) for _ in range(15)]
+    for kernel in ["gauss", "epan"]:
+        for h in [0.5, 1.0, 1.5]:
+            score, grad, _ = lscv_generic(x, h, kernel)
+            num_grad, _ = finite_diff(lambda hh: lscv_generic(x, hh, kernel)[0], h)
+            assert math.isclose(grad, num_grad, rel_tol=1e-4, abs_tol=1e-5)
diff --git a/tests/test_newton.py b/tests/test_newton.py
new file mode 100644
index 0000000..97db7b7
--- /dev/null
+++ b/tests/test_newton.py
@@ -0,0 +1,26 @@
+import random
+import math
+from .utils import lscv_generic, newton_opt
+
+
+def mixture_sample(n, rng):
+    samples = []
+    for _ in range(n):
+        if rng.random() < 0.5:
+            samples.append(rng.gauss(-2, 0.5))
+        else:
+            samples.append(rng.gauss(2, 1.0))
+    return samples
+
+
+def test_newton_matches_grid_search():
+    rng = random.Random(1)
+    x = mixture_sample(30, rng)
+    grid = [0.1 + i * (2.0 - 0.1) / 39 for i in range(40)]
+    for kernel in ["gauss", "epan"]:
+        scores = [lscv_generic(x, h, kernel)[0] for h in grid]
+        h_grid = grid[scores.index(min(scores))]
+
+        h_start = h_grid * 1.1
+        h_newton, _ = newton_opt(x, h_start, lambda data, h: lscv_generic(data, h, kernel))
+        assert math.isclose(h_newton, h_grid, rel_tol=0.1, abs_tol=0.05)
diff --git a/tests/utils.py b/tests/utils.py
new file mode 100644
index 0000000..e548a29
--- /dev/null
+++ b/tests/utils.py
@@ -0,0 +1,111 @@
+import math
+
+SQRT_2PI = math.sqrt(2 * math.pi)
+
+
+def K_gauss(u):
+    return math.exp(-0.5 * u * u) / SQRT_2PI
+
+def K_gauss_p(u):
+    return -u * K_gauss(u)
+
+def K_gauss_pp(u):
+    return (u * u - 1) * K_gauss(u)
+
+def K2_gauss(u):
+    return math.exp(-0.25 * u * u) / math.sqrt(4 * math.pi)
+
+def K2_gauss_p(u):
+    return -0.5 * u * K2_gauss(u)
+
+def K2_gauss_pp(u):
+    return (0.25 * u * u - 0.5) * K2_gauss(u)
+
+def K_epan(u):
+    a = abs(u)
+    return 0.75 * (1 - u * u) if a <= 1 else 0.0
+
+def K_epan_p(u):
+    a = abs(u)
+    return -1.5 * u if a <= 1 else 0.0
+
+def K_epan_pp(u):
+    a = abs(u)
+    return -1.5 if a <= 1 else 0.0
+
+def K2_epan(u):
+    a = abs(u)
+    if a <= 2:
+        return 0.6 - 0.75 * a ** 2 + 0.375 * a ** 3 - 0.01875 * a ** 5
+    return 0.0
+
+def K2_epan_p(u):
+    a = abs(u)
+    if a <= 2:
+        sign = 1 if u >= 0 else -1
+        return sign * (-0.09375 * a ** 4 + 1.125 * a ** 2 - 1.5 * a)
+    return 0.0
+
+def K2_epan_pp(u):
+    a = abs(u)
+    if a <= 2:
+        return -0.375 * a ** 3 + 2.25 * a - 1.5
+    return 0.0
+
+KERNELS = {
+    "gauss": (K_gauss, K_gauss_p, K_gauss_pp, K2_gauss, K2_gauss_p, K2_gauss_pp),
+    "epan": (K_epan, K_epan_p, K_epan_pp, K2_epan, K2_epan_p, K2_epan_pp),
+}
+
+def lscv_generic(x, h, kernel):
+    K, Kp, Kpp, K2, K2p, K2pp = KERNELS[kernel]
+    n = len(x)
+    score_term1 = 0.0
+    score_term2 = 0.0
+    S_F = 0.0
+    S_K = 0.0
+    S_F2 = 0.0
+    S_K2 = 0.0
+    for i in range(n):
+        for j in range(n):
+            u = (x[i] - x[j]) / h
+            k2 = K2(u)
+            k2p = K2p(u)
+            k2pp = K2pp(u)
+            score_term1 += k2
+            S_F += k2 + u * k2p
+            S_F2 += 2 * k2p + u * k2pp
+            if i != j:
+                k = K(u)
+                kp = Kp(u)
+                kpp = Kpp(u)
+                score_term2 += k
+                S_K += k + u * kp
+                S_K2 += 2 * kp + u * kpp
+    score = score_term1 / (n ** 2 * h) - 2 * (score_term2 / (n * (n - 1) * h))
+    grad = -S_F / (n ** 2 * h ** 2) + 2 * S_K / (n * (n - 1) * h ** 2)
+    hess = 2 * S_F / (n ** 2 * h ** 3) - S_F2 / (n ** 2 * h ** 2)
+    hess += -4 * S_K / (n * (n - 1) * h ** 3) + 2 * S_K2 / (n * (n - 1) * h ** 2)
+    return score, grad, hess
+
+def newton_opt(x, h0, score_grad_hess, tol=1e-5, max_iter=12):
+    """Newton–Armijo optimisation using a numeric Hessian estimate."""
+    h, evals = h0, 0
+    for _ in range(max_iter):
+        f, g, _ = score_grad_hess(x, h)
+        evals += 1
+        if abs(g) < tol:
+            break
+        eps = max(1e-4 * h, 1e-6)
+        _, g_plus, _ = score_grad_hess(x, h + eps)
+        H = (g_plus - g) / eps
+        step = -g / H if (H > 0 and math.isfinite(H)) else -0.25 * g
+        if abs(step) / h < 1e-3:
+            break
+        for _ in range(10):
+            h_new = max(h + step, 1e-6)
+            if score_grad_hess(x, h_new)[0] < f:
+                h = h_new
+                break
+            step *= 0.5
+    return h, evals