What should be done for version 1.84.2?

[alphp]

In dev-master new features and scripts are being introduced, but the tags allow to define a stable point of the code.

composer require fawno/fpdf:@stable

What should be done for the 1.84.2 tag?

• Documentation
• Check the content of the pdf created in the tests
• Must-have scripts
• Other features

The essential documentation is almost complete, missing some pages that I would like to have to release the 1.84.2 tag.

[angeljqv]

Everything looks stable, release it 👍

[erikn69]

Maybe a way to test the pdf results instead of just the creation, FPDF can create the file but the result can be not as expected

Ideas:
https://gordonlesti.com/phpunit-compare-generated-pdf-files-with-imagick/
https://karlomikus.com/blog/compare-pdf-files-using-php-and-imagemagick
https://github.com/heiglandreas/pdfunit

UPDATE:
what do you think about erikn69@9d6cc34?
Maybe can work, but i'm not sure, since two equal texts are being compared, it could be prone to errors in case of changes in FPDF

[alphp]

Comparing the generated document in the tests instead of only if it is generated is one of the things that I have in the to-do.

[alphp]

Added generated pdf vs reference pdf check:
#22 Check the content of the pdf created in the tests

[dealfonso]

Maybe a way to test the pdf results instead of just the creation, FPDF can create the file but the result can be not as expected

Ideas: https://gordonlesti.com/phpunit-compare-generated-pdf-files-with-imagick/ https://karlomikus.com/blog/compare-pdf-files-using-php-and-imagemagick https://github.com/heiglandreas/pdfunit

UPDATE: what do you think about erikn69@9d6cc34? Maybe can work, but i'm not sure, since two equal texts are being compared, it could be prone to errors in case of changes in FPDF

So that you are using sapp, it would be possible to rebuild the pdf documents (for both to be flattened and the multiple versions of the objects are removed) and then use the compare function to get the objects that are different.

[angeljqv]

Creo q todos hablamos español aqui, o no es asi?

[erikn69]

Parece que si, pero se usa ingles para ayudar a la comprensión de personas no hispano parlantes

[parallels999]

@dealfonso podrias agregar al readme.MD documentacion de como usar SAPP con PhpUnit para testear la generacion de PDFs(Talvez un trait para TestCase con los metodos listos para testear dos pdfs)

FPDF/tests/TestCase.php

Lines 46 to 59 in e8a8106

	public function assertPdfAreEquals (string $expected, string $actual) : void {
	$doc_expected = PDFDoc::from_string($expected);
	$this->assertIsObject($doc_expected);
	$doc_actual = PDFDoc::from_string($actual);
	$this->assertIsObject($doc_actual);
	$differences = $doc_expected->compare($doc_actual);
	foreach ($differences as $oid => $obj) {
	foreach ($obj->get_keys() as $key) {
	$this->assertTrue(in_array($key, ['Producer', 'CreationDate']));
	}
	}
	}

Y tambien a SAPP le falta el workflow con los tests, talvez a futuro se pueda agregar