Skip to content

Unify platform-specific files using generics and !linux tags#528

Closed
leoleovich wants to merge 1 commit into
mainfrom
unify-platform-files
Closed

Unify platform-specific files using generics and !linux tags#528
leoleovich wants to merge 1 commit into
mainfrom
unify-platform-files

Conversation

@leoleovich
Copy link
Copy Markdown
Contributor

  • clock: replace 3 arch-specific setters (386, 64bit, darwin) with one generic setTimexField[T] that handles int32/int64 at compile time
  • timestamp: merge darwin and freebsd into single notlinux file
  • ntp/responder/server: merge darwin and freebsd into single notlinux file
  • phc/unix: move CLOCK_MONOTONIC_RAW to linux.go (unavailable on FreeBSD)
  • ntpcheck: use phc/unix for CLOCK_MONOTONIC_RAW in track command
  • ping_test: remove unnecessary !race build tag

Summary

Test Plan

- clock: replace 3 arch-specific setters (386, 64bit, darwin) with one
  generic setTimexField[T] that handles int32/int64 at compile time
- timestamp: merge darwin and freebsd into single notlinux file
- ntp/responder/server: merge darwin and freebsd into single notlinux file
- phc/unix: move CLOCK_MONOTONIC_RAW to linux.go (unavailable on FreeBSD)
- ntpcheck: use phc/unix for CLOCK_MONOTONIC_RAW in track command
- ping_test: remove unnecessary !race build tag
@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 20, 2026
@meta-codesync
Copy link
Copy Markdown
Contributor

meta-codesync Bot commented May 20, 2026

@leoleovich has imported this pull request. If you are a Meta employee, you can view this in D105848057.

Copy link
Copy Markdown
Contributor

@ESoapW ESoapW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#m stackenblochen

@meta-codesync
Copy link
Copy Markdown
Contributor

meta-codesync Bot commented May 20, 2026

@leoleovich merged this pull request in ed6088d.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants