Skip to content

Improve Darwin and cross-platform support#527

Closed
leoleovich wants to merge 1 commit into
mainfrom
darwin_support
Closed

Improve Darwin and cross-platform support#527
leoleovich wants to merge 1 commit into
mainfrom
darwin_support

Conversation

@leoleovich
Copy link
Copy Markdown
Contributor

  • ntpcheck: replace 3 platform-specific setSocketTimeout helpers with one cross-platform implementation using unix.NsecToTimeval
  • ntpcheck: enable 'track' command on Darwin using unix.ClockGettime instead of raw SYS_CLOCK_GETTIME syscall
  • ziffy: slim down notlinux stubs, tag Linux-specific tests
  • timestamp: fix darwin test to match lowercased error string
  • cert: use require.Error instead of platform-specific x509 error type
  • utcoffset: create leap second test fixture when system file unavailable
  • leapsectz: add LeapFile/SetLeapFile accessors for test overrides

Summary

Test Plan

- ntpcheck: replace 3 platform-specific setSocketTimeout helpers with
  one cross-platform implementation using unix.NsecToTimeval
- ntpcheck: enable 'track' command on Darwin using unix.ClockGettime
  instead of raw SYS_CLOCK_GETTIME syscall
- ziffy: slim down notlinux stubs, tag Linux-specific tests
- timestamp: fix darwin test to match lowercased error string
- cert: use require.Error instead of platform-specific x509 error type
- utcoffset: create leap second test fixture when system file unavailable
- leapsectz: add LeapFile/SetLeapFile accessors for test overrides
@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 20, 2026
Copy link
Copy Markdown
Contributor

@vvfedorenko vvfedorenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@meta-codesync
Copy link
Copy Markdown
Contributor

meta-codesync Bot commented May 20, 2026

@leoleovich has imported this pull request. If you are a Meta employee, you can view this in D105842676.

@meta-codesync
Copy link
Copy Markdown
Contributor

meta-codesync Bot commented May 20, 2026

@leoleovich merged this pull request in dc28427.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants