Fix golangci-lint nilnil and revive signals (#526)#526
Closed
leoleovich wants to merge 1 commit into
Closed
Conversation
meta-cla
Bot
added
the
CLA Signed
Contributor
|
@leoleovich has exported this pull request. If you are a Meta employee, you can view the originating Diff in D105831114. |
meta-codesync
Bot
changed the title
leoleovich
added a commit
to leoleovich/time
that referenced
this pull request
May 20, 2026
Summary: Fix lint issues triggered by the Go 1.25 bump (D105819402): - nilnil: don't return both non-nil value and error - revive: remove unnecessary //nolint:revive on ENOENT Differential Revision: D105831114
leoleovich
force-pushed
the
export-D105831114
branch
from
7035658 to
22f6dd5
Compare
Summary: Fix lint issues triggered by the Go 1.25 bump (D105819402): - nilnil: don't return both non-nil value and error - revive: remove unnecessary //nolint:revive on ENOENT Differential Revision: D105831114
leoleovich
force-pushed
the
export-D105831114
branch
from
22f6dd5 to
ccb4910
Compare
Contributor
|
This pull request has been merged in 23c0765. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Fix lint issues triggered by the Go 1.25 bump (D105819402):
Differential Revision: D105831114