Skip to content

Fix clock tests for unsynced build environments (#523) #523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
leoleovich wants to merge 1 commit into from
Closed

Fix clock tests for unsynced build environments (#523) #523

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions clock/clock_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,16 +51,24 @@ func TestSetTimeNegative(t *testing.T) {
}

func TestFrequencyPPB(t *testing.T) {
tx := &unix.Timex{}
wantState, err := unix.Adjtimex(tx)
require.NoError(t, err)

freqPPB, state, err := FrequencyPPB(0)
require.NoError(t, err)
require.Equal(t, 0, state)
require.False(t, freqPPB != freqPPB) // not NaN
require.Equal(t, wantState, state)
require.Equal(t, float64(tx.Freq)/PPBToTimexPPM, freqPPB)
}

func TestMaxFreqPPB(t *testing.T) {
tx := &unix.Timex{}
wantState, err := unix.Adjtimex(tx)
require.NoError(t, err)

maxFreq, state, err := MaxFreqPPB(0)
require.NoError(t, err)
require.Equal(t, 0, state)
require.Equal(t, wantState, state)
require.Equal(t, 500000.0, maxFreq)
}

Expand Down
6 changes: 4 additions & 2 deletions fbclock/stats/stats_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,11 +119,13 @@ func TestConcurrentAccess(t *testing.T) {
s := NewStats()
var wg sync.WaitGroup
for i := range 100 {
wg.Go(func() {
wg.Add(1)
go func() {
defer wg.Done()
s.SetCounter("concurrent", int64(i))
s.UpdateCounterBy("incr", 1)
s.Get()
})
}()
}
wg.Wait()
got := s.Get()
Expand Down
Loading