Fix clock tests for unsynced build environments (#523)#523
Closed
leoleovich wants to merge 1 commit into
Closed
Conversation
meta-cla
Bot
added
the
CLA Signed
Contributor
|
@leoleovich has exported this pull request. If you are a Meta employee, you can view the originating Diff in D105576098. |
Summary: Remove state==TIME_OK assertion from TestFrequencyPPB and TestMaxFreqPPB. Build containers don't run NTP/chrony so clock_adjtime returns TIME_ERROR (5), not TIME_OK (0). The state value is system-dependent and not part of the function contract being tested. Differential Revision: D105576098
meta-codesync
Bot
changed the title
leoleovich
force-pushed
the
export-D105576098
branch
from
7f4c74e to
b91e539
Compare
Contributor
|
This pull request has been merged in a264de7. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Remove state==TIME_OK assertion from TestFrequencyPPB and TestMaxFreqPPB. Build containers don't run NTP/chrony so clock_adjtime returns TIME_ERROR (5), not TIME_OK (0). The state value is system-dependent and not part of the function contract being tested.
Differential Revision: D105576098