build: crate `esl01-indexedlog` fails to build on Rust 1.89

[claytonrcarter]

I'm a co-maintainer of git-branchless, and we recently received a report that our project won't build with Rust 1.89 due to an issue in the esl01-indexedlog crate. (We depend upon that crate indirectly, via the esl01-dag crate, which we use heavily.) The build error apparently relates to some code in esl01-indexedlog being incompatible with some file locking APIs having been newly stabilized in Rust 1.89.

The reported error seems to have been fixed in this project a few months ago, but that fix has not yet been published in an updated crate. That fix references Rust 1.84 as adding the new file locking API, but it seems that the new API was just stabilized for general release in Rust 1.89.

Is it possible for this fix to be published into an updated release of the esl01-indexedlog and/or esl01-dag crates?

• Report of build error: Fails to build with rust 1.89.0 arxanas/git-branchless#1585
• esl01-indexedlog crate @ 0.3.0: https://crates.io/crates/esl01-indexedlog/0.3.0
• esl01-dag crate @ 0.3.0: https://crates.io/crates/esl01-dag/0.3.0
• Commit in this repo that addressed this issue: 9e27acb
• Location of error with updated code: https://github.com/facebook/sapling/blob/main/eden/scm/lib/indexedlog/src/lock.rs#L242-L247
• Rust 1.89 Changelog of stablized APIs: https://releases.rs/docs/1.89.0/#stabilized-apis

Thank you!

[claytonrcarter]

Oh, I'm just now seeing similar crates named sapling-* on crates.io. Are these intended to be drop-in replacements for the esl01-* crates? If so, I can look into moving our project to the new crates, but I think that sapling-indexedlog may still need an update to pick up the change in 9e27acb.

[bryango]

It seems that the esl01-* crates are published from https://github.com/quark-zju/esl01-libs whose purpose was stated in a previous version of its README:

It might take some time for the upstream to publish crates on crates.io. For example, they might want 2-fac support which is currently not present in crates.io.

Before the upstream publishes the crates officially, this repository forks and renames the crates, then publishes them to crates.io with the new names that won't conflict with the upstream. Therefore those crates can actually be used in other projects that want to be published to crates.io, since crates.io does not allow dependencies in git sources.

Once 9e27acb is published in a new release I think we (git-branchless) can switch to the sapling-* crates instead. Friendly ping @quark-zju for comments 👋

[quark-zju]

I'm just now seeing similar crates named sapling-* on crates.io. Are these intended to be drop-in replacements for the esl01-* crates?

Yes.

I can take a look publishing related crates. Note some of the sapling-dag APIs have been switched to async compared to the initial esl01- crates. So you might need to wrap them in tokio's block_on (or something simpler like https://github.com/facebook/sapling/blob/main/eden/scm/lib/nonblocking/src/lib.rs if you'd like to avoid tokio complexity).